Ticket #3702 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

scaleFromLATTS function always returns 1

Reported by: mloskot Owned by: warmerdam
Priority: low Milestone:
Component: GDAL_Raster Version: svn-trunk
Severity: normal Keywords: ilwis
Cc:

Description

A minor issue spotted:

1. scaleFromLATTS function always returns 1 because return false; in line 380 is a dead code.

2. The function returns boolean by implicit conversion to int, perhaps intentional and perhaps not.

Change History

Changed 3 years ago by mloskot

  • cc ilwis removed
  • keywords ilwis added

Changed 3 years ago by rouault

  • status changed from new to closed
  • resolution set to fixed

I completely removed the return value as it wasn't used at all: r20192

Just curious: I imagine you didn't find this by code review ;-) What compiler/compiler options did you use to find this ?

Note: See TracTickets for help on using tickets.