Opened 14 years ago

Closed 14 years ago

#3702 closed defect (fixed)

scaleFromLATTS function always returns 1

Reported by: Mateusz Łoskot Owned by: warmerdam
Priority: low Milestone:
Component: GDAL_Raster Version: svn-trunk
Severity: normal Keywords: ilwis
Cc:

Description

A minor issue spotted:

  1. scaleFromLATTS​ function always returns 1 because return false; in line 380 is a dead code.
  1. The function returns boolean by implicit conversion to int, perhaps intentional and perhaps not.

Change History (2)

comment:1 by Mateusz Łoskot, 14 years ago

Cc: ilwis removed
Keywords: ilwis added

comment:2 by Even Rouault, 14 years ago

Resolution: → fixed
Status: new → closed

I completely removed the return value as it wasn't used at all: r20192

Just curious: I imagine you didn't find this by code review ;-) What compiler/compiler options did you use to find this ?

Note: See TracTickets for help on using tickets.