#3703 closed defect (fixed)
Ineffective setting of m_nVersion in AddFieldNative function
| Reported by: | Mateusz Łoskot | Owned by: | Daniel Morissette |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.8.0 |
| Component: | OGR_SF | Version: | unspecified |
| Severity: | normal | Keywords: | mitab |
| Cc: |
Description (last modified by )
In file mitab_miffile.cpp:1783, there is a suspicious case that looks like:
case TABFDateTime: ... break; m_nVersion = MAX(m_nVersion, 900); case TABFLogical: ...
The m_nVersion assignment is a dead code, perhaps unintentional.
Change History (4)
comment:1 by , 14 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 14 years ago
| Owner: | changed from to |
|---|
comment:3 by , 14 years ago
| Milestone: | → 1.8.0 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
comment:4 by , 14 years ago
| Cc: | removed |
|---|---|
| Keywords: | mitab added |
Note:
See TracTickets
for help on using tickets.
This was already fixed in the CVS master upstream (in mitab_miffile.cpp CVS r1.51 2009-07-27). Seems that we need to update the local copy from the master.
I committed the fix for this in SVN trunk r20158