Ticket #3703 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Ineffective setting of m_nVersion in AddFieldNative function

Reported by: mloskot Owned by: dmorissette
Priority: normal Milestone: 1.8.0
Component: OGR_SF Version: unspecified
Severity: normal Keywords: mitab
Cc:

Description (last modified by mloskot) (diff)

In file mitab_miffile.cpp:1783, there is a suspicious case that looks like:

case TABFDateTime:
   ...
   break;
   m_nVersion = MAX(m_nVersion, 900);
case TABFLogical:
...

The m_nVersion assignment is a dead code, perhaps unintentional.

Change History

Changed 3 years ago by mloskot

  • description modified (diff)

Changed 3 years ago by warmerdam

  • owner changed from warmerdam to dmorissette

Changed 3 years ago by dmorissette

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to 1.8.0

This was already fixed in the CVS master upstream (in mitab_miffile.cpp CVS r1.51 2009-07-27). Seems that we need to update the local copy from the master.

I committed the fix for this in SVN trunk r20158

Changed 3 years ago by mloskot

  • cc mitab removed
  • keywords mitab added
Note: See TracTickets for help on using tickets.