Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#1866 closed defect (fixed)

KML driver needs very new Expat

Reported by: warmerdam Owned by: Mateusz Łoskot
Priority: normal Milestone: 1.5.4
Component: OGR_SF Version: svn-trunk
Severity: normal Keywords: kml
Cc: Didge

Description

I get problems building kml driver with apparently older version of Expat. Stuff like missing definitioins for XMLCALL.

I would like a modest effort made to support older versions of Expat. In the meantime, I have modified kml.h with this check:

#ifndef XMLCALL
#error "Old version of expat, please upgrade to expat 2.x
#endif

Change History (7)

comment:1 Changed 12 years ago by Mateusz Łoskot

Status: newassigned

Frank,

I've successfully built GDAL with Expat 1.95.8 (2004-07-23) and Expat 2.0.1 (2007-06-05).

comment:2 Changed 12 years ago by Mateusz Łoskot

Resolution: fixed
Status: assignedclosed

comment:3 Changed 12 years ago by Mateusz Łoskot

Please, reopen if you've encountered new problems with older Expat.

comment:4 Changed 11 years ago by dron

Milestone: 1.6.0
Resolution: fixed
Status: closedreopened

This bug marled as fixed, but kml.h still contains

#error "Old version of expat, please upgrade to expat 2.x"

That probably should be either confirmed to be unneded or moved into configure script. At the moment we have a broken compilation on systems with old Expat libraries.

comment:5 Changed 11 years ago by Even Rouault

/usr/include/expat_external.h says "The XMLCALL macro was added in Expat 1.95.7."

comment:6 Changed 11 years ago by Even Rouault

Resolution: fixed
Status: reopenedclosed

Fixed in r15804. GPX and KML compiled and tested with Expat 1.95.0

comment:7 Changed 11 years ago by Even Rouault

Milestone: 1.6.01.5.4

Backported in branches/1.5 in r15807

Note: See TracTickets for help on using tickets.