Ticket #1866 (closed defect: fixed)

Opened 6 years ago

Last modified 4 years ago

KML driver needs very new Expat

Reported by: warmerdam Owned by: mloskot
Priority: normal Milestone: 1.5.4
Component: OGR_SF Version: svn-trunk
Severity: normal Keywords: kml
Cc: Didge

Description

I get problems building kml driver with apparently older version of Expat. Stuff like missing definitioins for XMLCALL.

I would like a modest effort made to support older versions of Expat. In the meantime, I have modified kml.h with this check: 

#ifndef XMLCALL
#error "Old version of expat, please upgrade to expat 2.x
#endif

Change History

Changed 6 years ago by mloskot

  • status changed from new to assigned

Frank,

I've successfully built GDAL with Expat 1.95.8 (2004-07-23) and Expat 2.0.1 (2007-06-05).

Changed 6 years ago by mloskot

  • status changed from assigned to closed
  • resolution set to fixed

Changed 6 years ago by mloskot

Please, reopen if you've encountered new problems with older Expat.

Changed 4 years ago by dron

  • status changed from closed to reopened
  • resolution fixed deleted
  • milestone set to 1.6.0

This bug marled as fixed, but kml.h still contains 

#error "Old version of expat, please upgrade to expat 2.x"

That probably should be either confirmed to be unneded or moved into configure script. At the moment we have a broken compilation on systems with old Expat libraries.

Changed 4 years ago by rouault

/usr/include/expat_external.h says "The XMLCALL macro was added in Expat 1.95.7."

Changed 4 years ago by rouault

  • status changed from reopened to closed
  • resolution set to fixed

Fixed in r15804. GPX and KML compiled and tested with Expat 1.95.0

Changed 4 years ago by rouault

  • milestone changed from 1.6.0 to 1.5.4

Backported in branches/1.5 in r15807

Note: See TracTickets for help on using tickets.