Opened 11 years ago

Closed 11 years ago

#16 closed enhancement (fixed)

Duplicates between geocent.js and proj4js.js

Reported by: dgrichard Owned by: madair
Priority: trivial Milestone: 1.0.0
Component: core Version:
Keywords: Cc:

Description

geocent.js redefines COS_67P5 and AD_C as global variables while they are already defined in proj4js.js
geocent.js makes use of HALF_PI, PJD_3PARAM and PJD_7PARAM instead of their Proj4js.common.* counterpart
geocent.js defines GEOCENT_LAT_ERROR as global variable
This patch proposes a fix for the above points.

Attachments (1)

geocent.diff (4.9 KB) - added by dgrichard 11 years ago.
the right diff format

Download all attachments as: .zip

Change History (5)

Changed 11 years ago by dgrichard

Attachment: geocent.diff added

the right diff format

comment:1 Changed 11 years ago by dgrichard

Type: defectenhancement

comment:2 Changed 11 years ago by madair

Status: newassigned

the contents of geocent.js is now included in proj4js.js and should probably be removed from the repository since it sin't used any longer. Does any of this patch apply to the Proj4js.Datum object in Proj4js.js?

comment:3 in reply to:  2 Changed 11 years ago by dgrichard

Replying to madair:

the contents of geocent.js is now included in proj4js.js and should probably be removed from the repository since it sin't used any longer. Does any of this patch apply to the Proj4js.Datum object in Proj4js.js?

Proj4js.datum is correct : none of the above path applies.

comment:4 Changed 11 years ago by madair

Resolution: fixed
Status: assignedclosed

removed from svn

Note: See TracTickets for help on using tickets.