Opened 10 years ago

Closed 9 years ago

#840 closed task (fixed)

Code Provenance Review

Reported by: robe Owned by: chodgson
Priority: medium Milestone: OSGeo incubation graduation
Component: management Version:
Keywords: Cc:

Description (last modified by robe)

OSGeo is getting a bit frustrated with our ineptness at completing the requisites to become an official Incubation project.

I'm sure they aren't the only ones. First on list is Code Provenance Review. I personally do not feel skilled enough to do this, but hope that strk, Mat, Paul or some others with more experience in these matters can take this on.

http://wiki.osgeo.org/index.php?title=PostGIS_Incubation_Status

Link to guidelines for writing one http://wiki.osgeo.org/wiki/Code_Provenance_Review

If we find issues also address them

Attachments (1)

trunk-r6856-copyright-grep.txt (28.0 KB) - added by mloskot 10 years ago.
Quick scan for Copyright to roughly estimate the current situation

Download all attachments as: .zip

Change History (13)

comment:1 Changed 10 years ago by robe

Description: modified (diff)

comment:2 Changed 10 years ago by robe

Description: modified (diff)

comment:3 Changed 10 years ago by robe

Description: modified (diff)

Changed 10 years ago by mloskot

Quick scan for Copyright to roughly estimate the current situation

comment:4 Changed 10 years ago by robe

For the tiger stuff we've been working on, I didn't see any copyright on the original files. I know Steve Frost and I forget who else he had working with him did a lot of work on it, so was going to put his name on (though I assume that is something he should probably do). Leo and I made corrections and added the reverse_geocoder and the cross platform loader generator.

As far as the original original, I assume it was done by Refractions, but not absolutely sure. Does anyone know the origination of the tiger geocoder we have. Its been there for as far back as I can remember.

comment:5 Changed 10 years ago by robe

Thank goodness for newsgroups. Well I guess this http://www.postgis.org/pipermail/postgis-users/2004-September/005762.html answers the question.

What's the rule on retroactively applying copyright?

comment:6 Changed 10 years ago by robe

Owner: set to robe

comment:7 Changed 10 years ago by chodgson

Owner: changed from robe to chodgson

So it would appear that most files have a header similar to:

/**********************************************************************
 * $Id:$
 *
 * PostGIS - Spatial Types for PostgreSQL
 * http://postgis.refractions.net
 * Copyright 2001-2011 Refractions Research Inc.
 *
 * This is free software; you can redistribute and/or modify it under
 * the terms of the GNU General Public Licence. See the COPYING file.
 *
 **********************************************************************/

I'd like to go through and add this header to all the files which have no header and no other copyright notice. Obviously not generated files, and using the appropriate comment format.

Is this reasonable?

comment:8 Changed 10 years ago by robe

+1 from me, Though I guess should wait for other PSCers to agree before you go ahead.

comment:9 Changed 10 years ago by chodgson

Status: newassigned

I have started a Provenance Review document here:

http://trac.osgeo.org/postgis/wiki/DevWikiProvenanceReview

I will make notes as per the OSGeo guidelines as I review the code.

comment:10 Changed 10 years ago by chodgson

Further to my earlier header question, should the header also be applied to the documentation .xml files? I guess I can't see why not. Though it might make sense to use a different license for the documentation since GPL is meant for code - something from creative commons perhaps? Although maybe we can't even change it easily at this point? (I am not a license guru).

comment:11 Changed 10 years ago by robe

Good point. Lets avoid the documentation for now. I've never much cared that our documentation is GPL. Would be nice to change it to a Creative Common of some sort if at all possible.

comment:12 Changed 9 years ago by strk

Resolution: fixed
Status: assignedclosed

All done. PostGIS graduated.

Note: See TracTickets for help on using tickets.