Opened 10 years ago

Closed 9 years ago

#819 closed defect (fixed)

topology regression testsuite: localized messages raise false positives

Reported by: aperi2007 Owned by: strk
Priority: medium Milestone: PostGIS 2.0.0
Component: topology Version: main
Keywords: Cc:

Description

Hi, compiling the trunk r I see an error in make check of createtopogeom. Attach the logs.

Attachments (4)

pgis_reg_13065.zip (1.5 KB) - added by aperi2007 10 years ago.
log errors
pgis_reg_24275.zip (1.5 KB) - added by aperi2007 10 years ago.
log erorr after make clean all check
pgis_reg_19659.zip (1.5 KB) - added by aperi2007 10 years ago.
log error with lang=C
error_log.zip (4.7 KB) - added by aperi2007 10 years ago.
two error log files

Download all attachments as: .zip

Change History (22)

Changed 10 years ago by aperi2007

Attachment: pgis_reg_13065.zip added

log errors

comment:1 Changed 10 years ago by strk

Please try 'make clean all check' from top-level dir.

Changed 10 years ago by aperi2007

Attachment: pgis_reg_24275.zip added

log erorr after make clean all check

comment:2 in reply to:  1 Changed 10 years ago by aperi2007

Replying to strk:

Please try 'make clean all check' from top-level dir.

I try, but still error

log attached

comment:3 Changed 10 years ago by strk

Ah! localization problem:

-PL/pgSQL function "createtopogeom" line 91 at EXECUTE statement
+funzione PL/pgSQL "createtopogeom" linea 91 a istruzione EXECUTE

Weird, as the run_test script sets LC_ALL=C Do you have LANG defined ? Or some other localization variable ?

comment:4 Changed 10 years ago by strk

It's weird because the db creation log does speak english instead:

psql:/home/postgres/software/postgis/postgis-2.0.0SVN/regress/../topology/topology.sql:3019: NOTICE:  aggregate topology.topoelementarray_agg(topology.topoelement) does not exist, skipping

comment:5 in reply to:  3 Changed 10 years ago by aperi2007

Replying to strk:

Ah! localization problem:

-PL/pgSQL function "createtopogeom" line 91 at EXECUTE statement
+funzione PL/pgSQL "createtopogeom" linea 91 a istruzione EXECUTE

Weird, as the run_test script sets LC_ALL=C Do you have LANG defined ? Or some other localization variable ?

yes, in the shell there is LANG=it_IT.UTF-8

comment:6 Changed 10 years ago by strk

can you please try setting LANG=C ?

comment:7 Changed 10 years ago by aperi2007

I try setting export LANG=C in the shell. After start postgres db and run make clean all check, always in the same shell. But still the error is here. log attach.

Changed 10 years ago by aperi2007

Attachment: pgis_reg_19659.zip added

log error with lang=C

comment:8 Changed 10 years ago by strk

Try running: $ env | grep it_IT and paste the result

comment:9 in reply to:  8 Changed 10 years ago by aperi2007

Replying to strk:

Try running: $ env | grep it_IT and paste the result

Here the result.

postgres@deb:~$ env | grep it_IT LANG=it_IT.UTF-8 postgres@deb:~$

comment:10 Changed 10 years ago by strk

There's nothing else then. Please try with r6786

comment:11 Changed 10 years ago by strk

Resolution: fixed
Status: newclosed

Assuming fixed ...

comment:12 Changed 10 years ago by aperi2007

Resolution: fixed
Status: closedreopened

Hi, I'm having still this error I don't know if it is a false positive. I guess it was never disappear.

I add my log error.

Changed 10 years ago by aperi2007

Attachment: error_log.zip added

two error log files

comment:13 Changed 10 years ago by aperi2007

I don't sure to understand what error was issuing. I see this error message.

 regress/createtopogeom. failed (diff expected obtained: /tmp/pgis_reg_9628/test_16_diff)
Run tests: 21
Failed: 1
make[2]: *** [check] Error 1
make[2]: Leaving directory `/home/postgres/software/postgis/postgis-2.0.0SVN/topology/test'
make[1]: *** [check] Error 2
make[1]: Leaving directory `/home/postgres/software/postgis/postgis-2.0.0SVN/topology'
make: *** [check] Error 1

But the logs generated are two "pgis_reg_5400 " and "pgis_reg_9628" I put both in the zip added.

comment:14 Changed 10 years ago by strk

checked, but it's still a localization issue. Does: env | grep it return anything else ?

comment:15 Changed 10 years ago by strk

Summary: topology: error on regress of createtopogeomtopology regression testsuite: localized messages raise false positives

Please consider appending RUNTESTFLAGS=-v to your 'make check' call next time:

make check RUNESTFLAGS=-v

That way you would get errors inline and avoid attachements.

comment:16 Changed 10 years ago by strk

Andrea: could you please try with r8555 ?

comment:17 Changed 9 years ago by strk

r9088 may have made this even stronger. Andrea: chances you can test again?

comment:18 Changed 9 years ago by aperi2007

Resolution: fixed
Status: reopenedclosed

I try it.

It work for me.

close the ticket.

Note: See TracTickets for help on using tickets.