Opened 10 years ago

Closed 9 years ago

#737 closed defect (fixed)

wmsservers get rid of deprecated calls

Reported by: robe Owned by: pramsey
Priority: medium Milestone: PostGIS 2.0.0
Component: postgis Version: master
Keywords: Cc:

Description

I'm in the thick of wiping out all the deprecated functions that have been deprecated since 1.2.

In cleaning up the regress: I cam across wmsservers which is filled with a butt load of ancient functions.

Paul can you verify these are still in use in Mapserver and GeoServer? and if so pull your strings to have them irradicated.

force2d, Asbinary,force_collection -- they all must go.

I'm playing bad cop now :)

Change History (4)

comment:1 Changed 10 years ago by robe

I renamed the old regress test to wmsservers_old and the revised one that doesn't use deprecated calls to wmsservers_new. The old one now fails. That's expected. I though I would leave it in case we have to create a special legacy_sorta.sql.c file to put these in.

I think we'll have issues with pgrouting too. Last I checked they are using a ton of deprecated functions I'm whiping out.

I guess people can install the legacy.sql.c. I don't think we have a make install for that file do we?

comment:2 Changed 10 years ago by strk

make check stops in the first directory where tests are not successful, so keeping wmsservers_old around and running prevents other tests from being run.

If it's expected to fail, please let's drop it, or have regress/run_test include the legacy stuff (or a mix of the two, if you have time to be very nice, like having a set of legacy tests which are run in their own dir with an additional --legacy switch to run_test, like I did for --topology)

comment:3 Changed 10 years ago by robe

strk, Okay I have removed it for now. It's just a reminder to Paul and really never intended to pass (unless of course we have to put those functions back before release), so don't see much of a point of creating a legacy section since the new PostGIS would never pass those tests under ideal conditions

comment:4 Changed 9 years ago by pramsey

Resolution: fixed
Status: newclosed

End of history, r8939

Note: See TracTickets for help on using tickets.