liblwgeom compile failure on PG17 and PG18 GHA runs

[robe]

​https://github.com/postgis/postgis/actions/runs/14012537588/job/39234117154

 libtool: link: ( cd ".libs" && rm -f "libryu.la" && ln -s "../libryu.la" "libryu.la" )
make[2]: Leaving directory '/src/postgis/deps/ryu'
libtool: compile:  gcc -I./../deps/ryu/.. -I/usr/local/include -I/usr/local/include -I/usr/include/x86_64-linux-gnu -I/usr/include/libxml2 -I/usr/local/include -I/usr/include/json-c -DNDEBUG -I. -I. -std=gnu11 -g -O0 --coverage -fno-math-errno -fno-signed-zeros -Wall -g -fPIC -DPIC -I/usr/local/include -c lwgeodetic.c -o lwgeodetic.o >/dev/null 2>&1
libtool: compile:  gcc -I./../deps/ryu/.. -I/usr/local/include -I/usr/local/include -I/usr/include/x86_64-linux-gnu -I/usr/include/libxml2 -I/usr/local/include -I/usr/include/json-c -DNDEBUG -I. -I. -std=gnu11 -g -O0 --coverage -fno-math-errno -fno-signed-zeros -Wall -g -fPIC -DPIC -I/usr/local/include -c topo/lwgeom_topo.c -o topo/lwgeom_topo.o >/dev/null 2>&1
make[1]: Leaving directory '/src/postgis/liblwgeom'
make: *** [GNUmakefile:36: all] Error 1

[robe]

Looks like it started failing with this commit

​https://github.com/postgis/postgis/commit/b159ebbe934c190fc874581fb5dbda6f9bd7453b

[robe]

Okay I missed the offending part

math-errno -fno-signed-zeros -Wall -g -fPIC -DPIC -I/usr/local/include -c lwpoly.c -o lwpoly.o >/dev/null 2>&1
In file included from lwgeom_sfcgal.h:26,
                 from lwgeom_sfcgal.c:25:
/usr/local/include/SFCGAL/capi/sfcgal_c.h:1287:69: error: expected ';', ',' or ')' before '=' token
 1287 |                                  double                   tolerance = 0.0);
      |                                                                     ^

[robe]

Okay this appears to be probably because of upgrade in sfcgal and so makes sense only the cis following sfcgal master failed.

[robe]

Related ticket on sfcgal - ​https://gitlab.com/sfcgal/SFCGAL/-/issues/300

[robe]

Fixed by ​https://gitlab.com/sfcgal/SFCGAL/-/commit/0f0f42c2ed0390069d20f89a7218fa62d7f86c68