#5852 closed enhancement (fixed)
Remove topogeo_addlinestring_expected from the .gitignore
Reported by: | evsi | Owned by: | strk |
---|---|---|---|
Priority: | low | Milestone: | PostGIS 3.5.3 |
Component: | topology | Version: | 3.0.x |
Keywords: | Cc: |
Description ¶
topogeo_addlinestring_expected has been in the .gitignore for over a decade https://git.osgeo.org/gitea/postgis/postgis/commit/c6f35551d6b7b58d3d1502ec8ad6dacb9a241680 However this file is not generated and is needed for tests.
If somebody pulls the PostGIS repo, then re-adds everything to commit it somewhere else, this file will be lost and the subsequent topogeo_addlinestring test will fail as the file is missing.
Dropping it from the .gitignore prevents that.
I sent the simple change to the osgeo git repo: https://git.osgeo.org/gitea/postgis/postgis/pulls/239
Change History (10)
comment:1 by , 2 months ago
comment:2 by , 2 months ago
Thanks! It looks to me like its needed on every stable-3.* branch (i.e. the file is not generated).
Merged in master branch as [202d59f44f2e3690038821f889e6506c3b553abf/git] — since you are at it do you want to check which stable-* branches need it ? It stopped being generated in 2017 with [d791b69518/git]