Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#5852 closed enhancement (fixed)

Remove topogeo_addlinestring_expected from the .gitignore

Reported by: evsi Owned by: strk
Priority: low Milestone: PostGIS 3.5.3
Component: topology Version: 3.0.x
Keywords: Cc:

Description

topogeo_addlinestring_expected has been in the .gitignore for over a decade https://git.osgeo.org/gitea/postgis/postgis/commit/c6f35551d6b7b58d3d1502ec8ad6dacb9a241680 However this file is not generated and is needed for tests.

If somebody pulls the PostGIS repo, then re-adds everything to commit it somewhere else, this file will be lost and the subsequent topogeo_addlinestring test will fail as the file is missing.

Dropping it from the .gitignore prevents that.

I sent the simple change to the osgeo git repo: https://git.osgeo.org/gitea/postgis/postgis/pulls/239

Change History (10)

comment:1 by strk, 2 months ago

Merged in master branch as [202d59f44f2e3690038821f889e6506c3b553abf/git] — since you are at it do you want to check which stable-* branches need it ? It stopped being generated in 2017 with [d791b69518/git]

comment:3 by Sandro Santilli <strk@…>, 2 months ago

In d5a837e1/git:

Remove topogeo_addlinestring_expected from .gitignore

It's not a generated file.

References #5852 in stable-3.1 branch (3.1.13dev)

comment:4 by Sandro Santilli <strk@…>, 2 months ago

In 4fbbfb9/git:

Remove topogeo_addlinestring_expected from .gitignore

It's not a generated file.

References #5852 in stable-3.2 branch (3.2.9dev)

comment:5 by Sandro Santilli <strk@…>, 2 months ago

In aaf02e1/git:

Remove topogeo_addlinestring_expected from .gitignore

It's not a generated file.

References #5852 in stable-3.3 branch (3.3.9dev)

comment:6 by Sandro Santilli <strk@…>, 2 months ago

In 1362852/git:

Remove topogeo_addlinestring_expected from .gitignore

It's not a generated file.

References #5852 in stable-3.4 branch (3.4.5dev)

comment:7 by Sandro Santilli <strk@…>, 2 months ago

In d3b7ee4b/git:

Remove topogeo_addlinestring_expected from .gitignore

It's not a generated file.

References #5852 in stable-3.5 branch (3.5.3dev)

comment:8 by Sandro Santilli <strk@…>, 2 months ago

Resolution: fixed
Status: newclosed

In c23e3e0/git:

Remove topogeo_addlinestring_expected from .gitignore

It's not a generated file.

Closes #5852 in stable-3.0 branch (3.0.12dev)

comment:9 by strk, 2 months ago

Version: 3.4.x3.0.x

Thanks a lot for your research, evsi

comment:10 by evsi, 2 months ago

thank you!

Note: See TracTickets for help on using tickets.