pg18 support

[RekGRpth]

does not compile under pg 18

#9 377.3 gserialized_estimate.c: In function 'compute_gserialized_stats_mode':
#9 377.3 gserialized_estimate.c:1508:17: error: too few arguments to function 'vacuum_delay_point'
#9 377.3  1508 |                 vacuum_delay_point();
#9 377.3       |                 ^~~~~~~~~~~~~~~~~~
#9 377.3 In file included from gserialized_estimate.c:97:
#9 377.3 /usr/local/include/postgresql/server/commands/vacuum.h:362:13: note: declared here
#9 377.3   362 | extern void vacuum_delay_point(bool is_analyze);
#9 377.3       |             ^~~~~~~~~~~~~~~~~~
#9 377.3 gserialized_estimate.c:1726:17: error: too few arguments to function 'vacuum_delay_point'
#9 377.3  1726 |                 vacuum_delay_point();
#9 377.3       |                 ^~~~~~~~~~~~~~~~~~
#9 377.3 /usr/local/include/postgresql/server/commands/vacuum.h:362:13: note: declared here
#9 377.3   362 | extern void vacuum_delay_point(bool is_analyze);
#9 377.3       |             ^~~~~~~~~~~~~~~~~~
#9 377.3 make[1]: *** [<builtin>: gserialized_estimate.o] Error 1
#9 377.3 make[1]: *** Waiting for unfinished jobs....
#9 378.8 make: *** [GNUmakefile:36: all] Error 1

[Laurenz Albe]

patch to fix the problem

[Laurenz Albe]

I stumbled over the same problem. Attached is a simple patch that should take care of the problem.

[Paul Ramsey <pramsey@…>]

In 1645baa9/git:

Allow build on PostgreSQL 18, closes #5851

[Regina Obe <lr@…>]

In a5e29aa/git:

Allow build on PostgreSQL 18, closes #5851
for PostGIS 3.6.0 master

[robe]

well it compiles now but giving this regress failure

 regress/core/regress_index .. failed (diff expected obtained: /tmp/pgis_reg/test_54_diff)
-----------------------------------------------------------------------------
--- ./regress/core/regress_index_expected	2025-03-03 02:49:45.864338590 +0000
+++ /tmp/pgis_reg/test_54_out	2025-03-03 02:51:35.699789217 +0000
@@ -10,12 +10,12 @@
 27373|POINT(125.017705 130.219927)
 33863|POINT(131.608071 127.468328)
 45851|POINT(130.986464 132.890625)
-&&|1|5+-5:true
-&&|2|912+-60:true
-&&|3|12505+-500:true
-&&|4|50000+-600:true
-expr &&|1|5+-5:true
-expr &&|2|912+-60:true
-expr &&|3|12505+-500:true
-expr &&|4|50000+-600:true
+&&|1|
+&&|2|
+&&|3|
+&&|4|
+expr &&|1|
+expr &&|2|
+expr &&|3|
+expr &&|4|
 _st_sortablehash|0|768602608280535040|768602608280535040

[Regina Obe <lr@…>]

In 73fcd56/git:

Fix regress error on pg18
Explain now returns fractional for actual rows for some reason
References #5851 for PostGIS 3.6.0

[Regina Obe <lr@…>]

In 8b1bb83/git:

Fix regress error on pg18
Explain now returns fractional for actual rows for some reason
Closes #5851 for PostGIS 3.5.3