Opened 12 days ago
Closed 34 hours ago
#5839 closed defect (duplicate)
Does not comile with postgres 18
Reported by: | RekGRpth | Owned by: | pramsey |
---|---|---|---|
Priority: | medium | Milestone: | PostGIS 3.5.3 |
Component: | postgis | Version: | master |
Keywords: | Cc: |
Description
Commit https://github.com/postgres/postgres/commit/d4a43b283751b23d32bbfa1ecc2cad2d16e3dde9 converts libpgport's pqsignal() to a void function.
#9 371.9 postgis_module.c: In function '_PG_init': #9 371.9 postgis_module.c:83:18: error: void value not ignored as it ought to be #9 371.9 83 | coreIntHandler = pqsignal(SIGINT, handleInterrupt); #9 371.9 | ^ #9 371.9 make[1]: *** [<builtin>: postgis_module.o] Error 1 #9 371.9 make[1]: *** Waiting for unfinished jobs.... #9 372.2 make: *** [GNUmakefile:36: all] Error 1
Note:
See TracTickets
for help on using tickets.
I'm hitting the same problem.
I think the right fix would be to get rid of
coreIntHandler
:_PG_fini()
could simply be removed (it is never called from PostgreSQL), andhandleInterrupt(int)
can just skip calling the previous interrupt handler.