Opened 3 months ago

Closed 3 months ago

#5784 closed patch (fixed)

Export circ_tree_distance_tree_internal and use memset instead of bzero

Reported by: mschoema Owned by: robe
Priority: medium Milestone: PostGIS 3.6.0
Component: liblwgeom Version: master
Keywords: Cc: mschoema

Description

In MobilityDB we embed liblwgeom to efficiently process PostGIS types. To update liblwgeom versions, we currently manually copy the files from PostGIS and then apply a few code changes that are required to compile it with MobilityDB. To simplify this process of updating liblwgeom versions, it would help if we coud simply copy the files without having to modify them after. This patch contains the manual changes that were necessary when updating from 3.4 to 3.5.

This patch exports the circ_tree_distance_tree_internal function that we are also interested in using and replaces a deprecate pzero call with a memset.

Attachments (1)

0001-export_circ_tree_dist.patch (2.4 KB ) - added by mschoema 3 months ago.

Download all attachments as: .zip

Change History (5)

by mschoema, 3 months ago

comment:1 by mschoema, 3 months ago

This is my first ticket, so I don't know the correct procedure for this.
I have pushed a commit with the changes to my fork. Let me know if I should open a PR.

https://git.osgeo.org/gitea/mschoema/postgis/commit/958f7e47ffc9108adda7b91938412787b1ce7020

in reply to:  1 comment:2 by robe, 3 months ago

Replying to mschoema:

This is my first ticket, so I don't know the correct procedure for this.
I have pushed a commit with the changes to my fork. Let me know if I should open a PR.

https://git.osgeo.org/gitea/mschoema/postgis/commit/958f7e47ffc9108adda7b91938412787b1ce7020

Much appreciated, yes open a PR would be great so we can all review and comment and our ci bot can check.

Last edited 3 months ago by robe (previous) (diff)

comment:3 by robe, 3 months ago

Owner: changed from strk to robe

comment:4 by Regina Obe <lr@…>, 3 months ago

Resolution: fixed
Status: newclosed

In 77bcee79/git:

export circ_tree_distance_tree_internal
and use memset instead of bzero
Closes #5784 for PostGIS 3.6.0

Note: See TracTickets for help on using tickets.