Opened 2 months ago

Last modified 5 days ago

#5727 new defect

Winnie Failing on topology_addline and topology_addlinerobust

Reported by: robe Owned by: strk
Priority: blocker Milestone: PostGIS 3.5.0
Component: topology Version: master
Keywords: robustness, testsuite, ci Cc:

Description

Winnie has been failing since April 30th. I thought it was GEOS so I rebuilt geos 3.13, but still failures.

Running after-create script ./regress/hooks/hook-after-create.sql
Executor slow factor: 13.4561 (134.561 ms to fetch full version)
PostgreSQL 15.6, compiled by Visual C++ build 1937, 64-bit
  Postgis 3.5.0dev - (3.4.0rc1-1105-gcb1a9e88e) - 2024-05-07 18:58:15
  scripts 3.5.0dev 3.4.0rc1-1105-gcb1a9e88e
  raster scripts 3.5.0dev 3.4.0rc1-1105-gcb1a9e88e
  GEOS: 3.13.0dev-CAPI-1.18.0

 ./topology/test/regress/topogeo_addlinestring_robust .. failed (diff expected obtained: /projects/postgis/tmp/3.5.0dev_pg15_geos3.13_gdal3.8.5w64/test_230_diff)
-----------------------------------------------------------------------------
--- ./topology/test/regress/topogeo_addlinestring_robust_expected	2024-04-30 15:13:51.265763100 -0400
+++ /projects/postgis/tmp/3.5.0dev_pg15_geos3.13_gdal3.8.5w64/test_230_out	2024-05-07 15:42:44.018142100 -0400
@@ -1,2 +1,4 @@
 #5699|-checking-
+#5699|addline exception|Spatial exception - geometry intersects edge 3 (XX000)
 #5711|-checking-
+#5711|addline exception|Spatial exception - geometry intersects edge 3 (XX000)
-----------------------------------------------------------------------------
 ./topology/test/regress/topogeo_addlinestring .. failed (diff expected obtained: /projects/postgis/tmp/3.5.0dev_pg15_geos3.13_gdal3.8.5w64/test_231_diff)
-----------------------------------------------------------------------------
--- ./topology/test/regress/topogeo_addlinestring_expected	2024-04-30 15:13:51.239393800 -0400
+++ /projects/postgis/tmp/3.5.0dev_pg15_geos3.13_gdal3.8.5w64/test_231_out	2024-05-07 15:42:51.331226400 -0400
@@ -171,8 +171,7 @@
 t3280.start|t
 t3280|L11
 t3280|L22
-t3280|L1b1
-t3280|L1b2
+ERROR:  Spatial exception - geometry intersects edge 2
 t3280.end|Topology 'bug3280' dropped
 t3380.start|t
 t3380.L1|1
-----------------------------------------------------------------------------
 ./topology/test/regress/topogeo_addpoint_merge_edges .. ok in 14071 ms

I'm going to test by downgrading testing to GEOS 3.12 to see if that resolves the issue

Change History (7)

comment:1 by strk, 2 months ago

Keywords: robustness testsuite ci added

Robustness tests are very fragile. I remember we had at some point to pass -ffloat-store compier switch to make results more stable, is this something done on the Windows build ? This is only happening on Windows, as far as we can tell ?

comment:2 by robe, 12 days ago

I did downgrade to 3.12 geos and still having the issue. Not just winnie but my local windows desktop. So yah robustness.

So far I think its just windows.

comment:3 by strk, 7 days ago

Any chance to get a remote access to any of those windows boxes ?

in reply to:  3 comment:4 by robe, 6 days ago

Replying to strk:

Any chance to get a remote access to any of those windows boxes ?

No. Not until I build a replacement windows ci

comment:5 by Regina Obe <lr@…>, 6 days ago

In 6c135f9c/git:

REMOVE topology robustness test failing on windows
References #5727 for PostGIS 3.5.0
Will put back after troubleshoot some more

comment:6 by Regina Obe <lr@…>, 6 days ago

In 5d5ed3b/git:

Put back topology tests, CI changes
but disable topology extension regress on winnie
References #5727 for PostGIS 3.5.0
Have tools.yml also use repo.osgeo.org instead of docker.osgeo.org

comment:7 by Regina Obe <lr@…>, 5 days ago

In 5f65069/git:

WINNIE CHANGES
Take out copying postgis topology libs to install folder
Cause topology is disabled building until windows topology fixed
References #5727 for PostGIS 3.5.0

Note: See TracTickets for help on using tickets.