Opened 8 months ago
Closed 7 months ago
#5704 closed defect (fixed)
Some regress tests are available but not enabled
Reported by: | strk | Owned by: | strk |
---|---|---|---|
Priority: | medium | Milestone: | PostGIS 3.2.8 |
Component: | QA/testsuite | Version: | 3.2.x |
Keywords: | Cc: |
Description
I've found that the utils/check_tests_enabled.sh script is failing to catch tests that are available but not enabled when their path contains the path of another enabled test.
Affected branches from 3.2 to main (3.5dev)
When fixed, various tests are found to be not enabled.
Change History (27)
comment:1 by , 8 months ago
comment:15 by , 8 months ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
okay looks like enabling geography_centroid broke bessie32
10:24:00 regress/core/geography_centroid .. failed (diff expected obtained: /home/jenkins/tmp/pgis_reg_94437b68118a4cbee3a9b86e73c2b2971285aa6f/test_20_diff) 10:24:00 ----------------------------------------------------------------------------- 10:24:00 --- ./regress/core/geography_centroid_expected 2024-03-28 10:17:55.434981000 -0400 10:24:00 +++ /home/jenkins/tmp/pgis_reg_94437b68118a4cbee3a9b86e73c2b2971285aa6f/test_20_out 2024-03-28 10:24:00.893251000 -0400 10:24:00 @@ -1,8 +1,8 @@ 10:24:00 geog_centroid_mpt_pole_north|0101000020E610000000000000000000000000000000805640 10:24:00 geog_centroid_mpt_pole_south|0101000020E6100000000000000000000000000000008056C0 10:24:00 geog_centroid_mpt_idl_1|0101000020E610000000000000008066400000000000000000 10:24:00 -geog_centroid_mpt_idl_2|0101000020E610000000000000007066400000000000000000 10:24:00 -geog_centroid_mpt_idl_3|0101000020E610000000000000007066C00000000000000000 10:24:00 +geog_centroid_mpt_idl_2|0101000020E6100000FFFFFFFFFF6F66400000000000000000 10:24:00 +geog_centroid_mpt_idl_3|0101000020E6100000FFFFFFFFFF6F66C00000000000000000 10:24:00 geog_centroid_pt_self_1|0101000020E610000000000000000010400000000000002040 10:24:00 geog_centroid_pt_self_2|0101000020E61000000000000000002EC00000000000003040 10:24:00 geog_centroid_pt_self_3|0101000020E610000000000000000037C000000000000045C0 10:24:00 -----------------------------------------------------------------------------
comment:16 by , 8 months ago
This looks to be just a rounding issue so will fix:
{{{ — POINT(179.49999999999997 0) SELECT ST_ASText('0101000020E6100000FFFFFFFFFF6F66400000000000000000'::geometry);
— POINT(179.5 0) SELECT ST_ASText('0101000020E610000000000000007066400000000000000000'::geometry); }}}
comment:18 by , 8 months ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Will backport once confirmed works on master. For the record berrie and berrie64 had the same issue.
comment:19 by , 8 months ago
It appears the berries are still unsatisfied
04:25:23 -geog_centroid_mpt_idl_1|POINT(180 0) 04:25:23 -geog_centroid_mpt_idl_2|POINT(179.5 0) 04:25:23 -geog_centroid_mpt_idl_3|POINT(-179.5 0) 04:25:23 +geog_centroid_mpt_idl_1|POINT(180 -5.3442080106e-19) 04:25:23 +geog_centroid_mpt_idl_2|POINT(179.5 -1.2026376291e-18) 04:25:23 +geog_centroid_mpt_idl_3|POINT(-179.5 -1.2026376291e-18)
comment:27 by , 7 months ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
The tests found disabled in master branch:
A fix for the checking script: https://git.osgeo.org/gitea/postgis/postgis/pulls/197