Opened 8 months ago

Closed 7 months ago

#5704 closed defect (fixed)

Some regress tests are available but not enabled

Reported by: strk Owned by: strk
Priority: medium Milestone: PostGIS 3.2.8
Component: QA/testsuite Version: 3.2.x
Keywords: Cc:

Description

I've found that the utils/check_tests_enabled.sh script is failing to catch tests that are available but not enabled when their path contains the path of another enabled test.

Affected branches from 3.2 to main (3.5dev)

When fixed, various tests are found to be not enabled.

Change History (27)

comment:1 by strk, 8 months ago

The tests found disabled in master branch:

  • regress/core/geography_centroid
  • regress/core/geography_covers
  • topology/test/regress/validatetopologyrelation.sql

A fix for the checking script: https://git.osgeo.org/gitea/postgis/postgis/pulls/197

comment:2 by Sandro Santilli <strk@…>, 8 months ago

In 6e3f86d/git:

Fix geography_covers test syntax

It was broken by 51ff306d3f32217d00e9511cfe9463ddb0523adb
but the test was not running in CI

References #5704 in master branch (3.5.0dev)

comment:3 by Sandro Santilli <strk@…>, 8 months ago

In fd60714/git:

Make geography_centroid tests tolerant to subtle differences

Check up to 10 decimal digits in text form

The test otherwise fails with 3.13.0dev-CAPI-1.18.0
but was not running in CI

References #5704 in master branch (3.5.0dev)

comment:4 by Sandro Santilli <strk@…>, 8 months ago

In b0698d2/git:

Enable accidentally disabled tests

These are:

  • regress/core/geography_centroid
  • regress/core/geography_covers
  • topology/test/regress/validatetopologyrelation.sql

References #5704 in master branch (3.5.0dev)

comment:5 by Sandro Santilli <strk@…>, 8 months ago

In 94437b68/git:

Fix check for enabled tests

References #5704 in master branch (3.5.0dev)

comment:6 by Sandro Santilli <strk@…>, 8 months ago

In 0d08721/git:

Make geography_centroid tests tolerant to subtle differences

Check up to 10 decimal digits in text form

The test otherwise fails with 3.13.0dev-CAPI-1.18.0
but was not running in CI

References #5704 in 3.4 branch (3.4.3dev)

comment:7 by Sandro Santilli <strk@…>, 8 months ago

In bbd06a2c/git:

Enable accidentally disabled tests

These are:

  • regress/core/geography_centroid
  • regress/core/geography_covers
  • topology/test/regress/validatetopologyrelation.sql

References #5704 in 3.4 branch (3.4.3dev)

comment:8 by Sandro Santilli <strk@…>, 8 months ago

In 2d4aed4/git:

Fix check for enabled tests

References #5704 in 3.4 branch (3.4.3dev)

comment:9 by Sandro Santilli <strk@…>, 8 months ago

In 63b8bab/git:

Make geography_centroid tests tolerant to subtle differences

Check up to 10 decimal digits in text form

The test otherwise fails with 3.13.0dev-CAPI-1.18.0
but was not running in CI

References #5704 in 3.3 branch (3.3.7dev)

comment:10 by Sandro Santilli <strk@…>, 8 months ago

In c82930f/git:

Fix check for enabled tests

References #5704 in 3.3 branch (3.3.7dev)

comment:11 by Sandro Santilli <strk@…>, 8 months ago

In 976f101/git:

Enable accidentally disabled tests

These are:

  • regress/core/geography_centroid
  • regress/core/geography_covers
  • topology/test/regress/validatetopologyrelation.sql

References #5704 in 3.3 branch (3.3.7dev)

comment:12 by Sandro Santilli <strk@…>, 8 months ago

In cddc4c8/git:

Make geography_centroid tests tolerant to subtle differences

Check up to 10 decimal digits in text form

The test otherwise fails with 3.13.0dev-CAPI-1.18.0
but was not running in CI

References #5704 in 3.2 branch (3.2.8)

comment:13 by Sandro Santilli <strk@…>, 8 months ago

In 5c3cc236/git:

Enable accidentally disabled tests

These are:

  • regress/core/geography_centroid
  • regress/core/geography_covers
  • topology/test/regress/validatetopologyrelation.sql

References #5704 in 3.2 branch (3.2.8)

comment:14 by Sandro Santilli <strk@…>, 8 months ago

Resolution: fixed
Status: newclosed

In be8b258d/git:

Fix check for enabled tests

Closes #5704 in 3.2 branch (3.2.8)

comment:15 by robe, 8 months ago

Resolution: fixed
Status: closedreopened

okay looks like enabling geography_centroid broke bessie32

10:24:00  regress/core/geography_centroid .. failed (diff expected obtained: /home/jenkins/tmp/pgis_reg_94437b68118a4cbee3a9b86e73c2b2971285aa6f/test_20_diff)
10:24:00 -----------------------------------------------------------------------------
10:24:00 --- ./regress/core/geography_centroid_expected	2024-03-28 10:17:55.434981000 -0400
10:24:00 +++ /home/jenkins/tmp/pgis_reg_94437b68118a4cbee3a9b86e73c2b2971285aa6f/test_20_out	2024-03-28 10:24:00.893251000 -0400
10:24:00 @@ -1,8 +1,8 @@
10:24:00  geog_centroid_mpt_pole_north|0101000020E610000000000000000000000000000000805640
10:24:00  geog_centroid_mpt_pole_south|0101000020E6100000000000000000000000000000008056C0
10:24:00  geog_centroid_mpt_idl_1|0101000020E610000000000000008066400000000000000000
10:24:00 -geog_centroid_mpt_idl_2|0101000020E610000000000000007066400000000000000000
10:24:00 -geog_centroid_mpt_idl_3|0101000020E610000000000000007066C00000000000000000
10:24:00 +geog_centroid_mpt_idl_2|0101000020E6100000FFFFFFFFFF6F66400000000000000000
10:24:00 +geog_centroid_mpt_idl_3|0101000020E6100000FFFFFFFFFF6F66C00000000000000000
10:24:00  geog_centroid_pt_self_1|0101000020E610000000000000000010400000000000002040
10:24:00  geog_centroid_pt_self_2|0101000020E61000000000000000002EC00000000000003040
10:24:00  geog_centroid_pt_self_3|0101000020E610000000000000000037C000000000000045C0
10:24:00 -----------------------------------------------------------------------------

comment:16 by robe, 8 months ago

This looks to be just a rounding issue so will fix:

{{{ — POINT(179.49999999999997 0) SELECT ST_ASText('0101000020E6100000FFFFFFFFFF6F66400000000000000000'::geometry);

— POINT(179.5 0) SELECT ST_ASText('0101000020E610000000000000007066400000000000000000'::geometry); }}}

comment:17 by Regina Obe <lr@…>, 8 months ago

Resolution: fixed
Status: reopenedclosed

In 7215219/git:

Fix regression issue on 32-bit
Closes #5704 for PostGIS 3.5.0

comment:18 by robe, 8 months ago

Resolution: fixed
Status: closedreopened

Will backport once confirmed works on master. For the record berrie and berrie64 had the same issue.

comment:19 by robe, 8 months ago

It appears the berries are still unsatisfied

04:25:23 -geog_centroid_mpt_idl_1|POINT(180 0)
04:25:23 -geog_centroid_mpt_idl_2|POINT(179.5 0)
04:25:23 -geog_centroid_mpt_idl_3|POINT(-179.5 0)
04:25:23 +geog_centroid_mpt_idl_1|POINT(180 -5.3442080106e-19)
04:25:23 +geog_centroid_mpt_idl_2|POINT(179.5 -1.2026376291e-18)
04:25:23 +geog_centroid_mpt_idl_3|POINT(-179.5 -1.2026376291e-18)

comment:20 by Regina Obe <lr@…>, 8 months ago

In ebad0ba/git:

Fix regression issue on 32-bit
and arm failures
References #5704 for PostGIS 3.5.0

comment:21 by Regina Obe <lr@…>, 8 months ago

In 4c6328b/git:

Fix regression issue on 32-bit
and arm failures
References #5704 for PostGIS 3.5.0

comment:22 by Regina Obe <lr@…>, 8 months ago

In 3e28490/git:

Fix regression issue on 32-bit
and arm failures
References #5704 for PostGIS 3.5.0

comment:23 by Regina Obe <lr@…>, 8 months ago

In 3a9d2eb/git:

Fix regression issue on 32-bit
and arm failures
References #5704 for PostGIS 3.5.0

comment:24 by Regina Obe <lr@…>, 8 months ago

In 8065be5/git:

Fix regression issue on 32-bit
and arm failures
References #5704 for PostGIS 3.4.3

comment:25 by Regina Obe <lr@…>, 8 months ago

In 72946a2/git:

Fix regression issue on 32-bit
and arm failures
References #5704 for PostGIS 3.3.7

comment:26 by Regina Obe <lr@…>, 8 months ago

In 2399e909/git:

Fix regression issue on 32-bit
and arm failures
References #5704 for PostGIS 3.2.8

comment:27 by robe, 7 months ago

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.