Opened 13 months ago
Last modified 3 months ago
#5618 reopened defect
Images not showing
Reported by: | robe | Owned by: | robe |
---|---|---|---|
Priority: | blocker | Milestone: | PostGIS 3.6.0 |
Component: | documentation | Version: | master |
Keywords: | Cc: |
Description
I suspect images aren't being installed in postgis.net. I say so because the new SFCGAL images I created, I see in the PDF but are missing on the website.
Example case
https://postgis.net/docs/manual-dev/en/CG_YMonotonePartition.html
There should be an image - https://postgis.net/docs/manual-dev/images/cg_ymonotonepartition01.png
and it shows in the generated PDF here - https://postgis.net/stuff/postgis-3.5-en.pdf
Change History (6)
comment:1 by , 13 months ago
Summary: | Images not installing → Images not showing |
---|
comment:2 by , 13 months ago
Okay must be something wrong with my nginx config that maybe the 3.5 is reading an older folder. Will look into it.
comment:3 by , 13 months ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Okay was nginx rule forcing all images to match to the 3.4 images.
To fix had to change in /etc/nginx/sites-available/postgis.net.conf
# rewrite docs links and css, this is because manual # /docs images look up one so expect to see docs at the root rewrite /images/(.*) /docs/images/$1; rewrite /style.css /docs/style.css;
to
# rewrite docs links and css, this is because manual # /docs images look up one so expect to see docs at the root rewrite ^/images/(.*) /docs/images/$1; rewrite ^/style.css /docs/style.css;
I didn't notice until we had new images that everything was looking in manual-3.4/images because all prior images are subset of those except for 3.5 with these new images.
I did a quick spot check of 3.1 and 3.5 and manual-dev and images all seem to show up okay
comment:4 by , 12 months ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Martin pointed out the https://postgis.net/docs/manual-dev/ST_SimplifyPreserveTopology.html images not showing so this apparently is not fixed.
comment:5 by , 12 months ago
Okay it seems the images are written as ../images/st_simplifypreservetopology01.png and that is putting them at /docs/images instead of /docs/manual-dev/images.
But I guess I was looking at the translated docs, cause ../images puts the images in the right spot for the translated docs
e.g. images show up here:
https://postgis.net/docs/manual-dev/en/ST_SimplifyPreserveTopology.html
comment:6 by , 3 months ago
Milestone: | PostGIS 3.5.0 → PostGIS 3.6.0 |
---|
on closer inspection, I see the files in the web images folder and they look to have same permissions as other files.
But yet this one shows
https://postgis.net/docs/manual-3.5/images/apple.png
and this one doesn't show https://postgis.net/docs/manual-3.5/images/cg_approxconvexpartition01.png
I'll need to check the web logs to see what's up. I thought maybe there was something special about the st_ prefix, but clearly things like apple.png shows, though that is a static image.