Remove the workaround for pgaudit being too verbose.

[mnencia]

As a solution for issue #5076, a check was added to prevent the installation of the postgis extension if pgaudit is installed and logging.

However, the pgaudit maintainers fixed the issue in the Feb 25, 2022 release.

Current versions of pgaudit don't log any statement issued during the create extension execution. (See ​https://github.com/pgaudit/pgaudit/commit/6460d9fec78c344245c70309551bb314415268a8)

I suggest that we either remove the pgaudit check or limit it to older versions only.

[robe]

I think for PostGIS 3.5.0 we can dispense with the pgaudit version check. I figure 9 months from now is far enough that people should have made the switch in pgaudit already.

As to for PostGIS 3.4.1 2022 is not that long ago that I wouldn't be a little worried. That said pramsey you have a sense of percentage of people that would be impacted if we remove this from PostGIS 3.4? I wouldn't bother with PostGIS 3.3 since there is a much higher chance a person installing PostGIS 3.3 is running with an older pgaudit

[pramsey]

Well, from an "employer" point of view, the motivation to add that check has receded since we are up to date on versions on CrunchyBridge, so it would be nice if PostGIS 3.5 dropped the check. It would be opening up the footgun again for people who happened to be running old versions of pgaudit, for whatever reason.

[robe]

@pramsey so how do you feel about dropping it in PostGIS 3.4.1, or should we just push that can down the road? Doing version audits sounds like it would take a bit more care and testing.

I'd like to release 3.4.1 soon like this weekend, and trying to shove this in quickly feels a little wrong, so I'd rather just make this a 3.5.0 thing, or maybe a 3.4.2 thing where we can spend more time on 3.4.2 deciding how to do the version checking or if we even care to.