ERROR: cannot change name of input parameter "gj_version"

[strk]

Spotted with:

regress/run_test.pl -v —extension —upgrade-path=2.5.7—3.5.0dev regress/core/legacy

Gets here:

-----------------------------------------------------------------------------
--- regress/core/legacy_expected        2023-09-01 07:52:46.900420710 +0000
+++ /tmp/pgis_reg/test_1_out    2023-09-01 10:45:13.215427704 +0000
@@ -1,3 +1,4 @@
+ERROR:  cannot change name of input parameter "gj_version"
 Starting up MapServer/Geoserver tests...
 Setting up the data table...
 public.wmstest.pt SRID:4326 TYPE:POLYGON DIMS:2
@@ -17,3 +18,6 @@
 Removing the data table...
 Done.
 1869|POINT(1 2)
+ERROR:  cannot drop function st_asgeojson(integer,geometry,integer,integer) because extension postgis requires it
+ERROR:  current transaction is aborted, commands ignored until end of transaction block
+ERROR:  current transaction is aborted, commands ignored until end of transaction block
-----------------------------------------------------------------------------

postgis/legacy.sql:2160: ERROR: cannot change name of input parameter "gj_version"

The offending signature is NOT marked as dropped in 3.0 in the postgis_after_upgrade.sql, closest is this (note the underscore)

SELECT _postgis_drop_function_by_signature('_ST_AsGeoJson(int4, geometry, int4, int4)'); — dropped in PostGIS-3.0 (r17300)

[Sandro Santilli <strk@…>]

In b175b63e/git:

Drop ST_AsGeoJSON(int4,geometry,int4,int4) sig deprecated in 3.0

References #5523 in master (3.5.0dev) branch

[strk]

Closed by [e428b70577bd51d3924346d9f0124a6d37ef4ff8/git] in 3.4 branch (3.4.1dev)