ERROR: cannot drop function st_mapalgebrafct(raster,regprocedure) because other objects depend on it

[strk]

Triggered by make check-locked-upgrade RUNTESTFLAGS=-v in master branch

[strk]

There are 7 variants of the ST_MapAlgebraFct function, and 11 of them are in upgrade_cleanup.sql documented as having had signature or parameter names changed. Additionally there was a signature completely removed.

Pain points ++

[strk]

The postgis core before-upgrade script is somewhat smarter as it uses a _drop_function_if_needed taking also parameter names, so it won't drop functions if they are not really deprecated.

It would be a good step forward to re-use that code in the raster part. Of course doing so would require finding out the name of parameters over time.

[strk]

None of the current 7 ST_MapAlgebraFct changed since PostGIS 2.0.0 which was the first version having raster support integrated.

I'll remove the drops and not care about upgrading from WKTRaster times

[Sandro Santilli <strk@…>]

In 83c9005/git:

Fix upgrade with objects using ST_MapAlgebraFCT

Also adds availability info to the function signatures.

References #5500 in master branch (3.5.0dev)

[Sandro Santilli <strk@…>]

In c2a5f1c9/git:

Fix upgrade with objects using ST_MapAlgebraFCT

Also adds availability info to the function signatures.

Closes #5500 in 3.4 branch (3.4.1dev)