Opened 8 months ago

Closed 5 months ago

#5497 closed enhancement (fixed)

Test double upgrades with locking views

Reported by: strk Owned by: pramsey
Priority: medium Milestone: PostGIS 3.5.0
Component: postgis Version: master
Keywords: Cc:


The bug reported in #5494 only affects running an upgrade procedure twice while a view holds back some deprecated function.

This resulted in no bots ever catching it, which is a pity. This ticket is to improve the testsuite to also test this case.

The double upgrade could re-use the existing pre-upgrade hooks to install the locking views, then run an ad-hoc test running an additional upgrade, and call all of this via —upgrade which would be doing the first upgrade.

I've done this locally but would like to automate it somehow.

I think running ALL tests would be overkill so this is really something we only want to do with an ad-hoc test

Change History (7)

comment:1 by Sandro Santilli <strk@…>, 8 months ago

In 84ed9355/git:

Have dronie and woodie test double-upgrades

References #5497 in master branch

comment:2 by Sandro Santilli <strk@…>, 8 months ago

In a48a238/git:

Have woodie and dronie check locked upgrade for core

References #5497

comment:3 by Sandro Santilli <strk@…>, 8 months ago

In 2cff249/git:

Have after-upgrade hook drop view created by use-all-functions.sql

Fixes make -C regress check-locked-upgrade

Also encode some skips due to known bugs

References #5497

comment:4 by Sandro Santilli <strk@…>, 8 months ago

In 148267b/git:

Drop the upgrade test schema before the deprecated functions

Ensures the deprecated functions can be removed safely

References #5497

comment:5 by Sandro Santilli <strk@…>, 8 months ago

In 27974085/git:

Drop any deprecated_by_postgis function after upgrade test

Fixes make -C regress/ check-locked-upgrade for real

References #5497

comment:6 by Sandro Santilli <strk@…>, 8 months ago

In e9df666/git:

Skip all problematic raster functions from locking view

Have dronie/woodie run locked upgrade test also for raster

References #5497
References #5516

comment:7 by strk, 5 months ago

Resolution: fixed
Status: newclosed

At the moment "locked upgrade" is always tested by make check, due to regress/ including the use_all_functions.sql hook. This means make check-double-upgrade is already testing locked-double-upgrade and both Dronie and Woodie are running make check-double-upgrade, so I'll close this ticket as completed.

Note: See TracTickets for help on using tickets.