Upgrade from 3.1.1: ERROR: cannot drop function st_intersects(raster,geometry,integer) because other objects depend on it

[strk]

Another case of upgrade trouble:

=# select postgis_extensions_upgrade();
NOTICE:  Updating extension postgis from 3.1.1 to 3.4.0
NOTICE:  Updating extension postgis_sfcgal from 3.1.1 to 3.4.0
NOTICE:  Updating extension postgis_raster from 3.1.1 to 3.4.0
ERROR:  cannot drop function st_intersects(raster,geometry,integer) because other objects depend on it

See also #5488

[strk]

Current signatures (3.5.0dev, same as 2.0.0):

 -- 1. st_intersects(rast1 raster, nband1 integer, rast2 raster, nband2 integer)
 -- 2. st_intersects(rast1 raster, rast2 raster)
 -- 3. st_intersects(geom geometry, rast raster, nband integer DEFAULT NULL)
 -- 4. st_intersects(rast raster, geom geometry, nband integer DEFAULT NULL)
 -- 5. st_intersects(rast raster, nband integer, geom geometry)

A lot of ST_Intersects signatures are dropped in 2.0.0, which doesn't make much sense as 2.0 was the first version including raster.

I think I'm going to stop dropping them all and call it a day.

[strk]

The other 2 internal signatures which did not change from 2.0.0 to 3.5.0dev are:

1. _st_intersects(geom geometry, rast raster, nband integer DEFAULT NULL)
2. _st_intersects(rast1 raster, nband1 integer, rast2 raster, nband2 integer)

Additionally stable-2.0 (dropped in stable-2.1) had:

3. _st_intersects(rast raster, geom geometry, nband integer DEFAULT NULL)

[strk]

Bug confirmed by CI: ​https://woodie.osgeo.org/repos/30/pipeline/865/7 about to push the fix

[strk]

Fix confirmed by CI: ​https://woodie.osgeo.org/repos/30/pipeline/866

[Sandro Santilli <strk@…>]

In 99ddb20a/git:

Fix upgrades in presence of views using st_intersects(..raster..)

Includes regress tests

References #5489 in master branch (3.5.0dev)

[Sandro Santilli <strk@…>]

In df07c29/git:

Fix upgrades in presence of views using st_intersects(..raster..)

Includes regress tests

Closes #5489 in 3.4 branch (3.4.1dev)