Opened 17 months ago

Closed 17 months ago

#5470 closed defect (fixed)

make installcheck for address_standardizer expects incorrectly formatted output

Reported by: tbussmann Owned by: robe
Priority: medium Milestone: PostGIS 3.4.0
Component: pagc_address_parser Version: master
Keywords: Cc: strk

Description

In [8cebf5d6/git] a new test for address_standardizer was added: test-debug_standardize_address. However it's expected output file was trimmed of trailing whitespace which results in make installcheck complaining on the differences.

Attached a trivial patch to fix this.

Attachments (1)

postgis_check_address_standardizer.patch​ (3.6 KB ) - added by tbussmann 17 months ago.

Download all attachments as: .zip

Change History (5)

by tbussmann, 17 months ago

Attachment: postgis_check_address_standardizer.patch​ added

comment:1 by robe, 17 months ago

Cc: strk added

Damn I thought we fixed this already. Maybe my editor config broke it on my last commit.

@strk remember how you fixed this last time?

comment:2 by tbussmann, 17 months ago

Yes, you remember correctly - a similar issue was fixed in [e6d6be31/git] (master) and [a5c0cb9/git] (3.3, see #5409) but for a different test test-standardize_address_1. Seeing this kind of issue repeatedly, looks like there is an issue with the editor or git config somewhere.

The patch attached to this ticket should fix it. Or do you prefer a PR?

Last edited 17 months ago by tbussmann (previous) (diff)

comment:3 by robe, 17 months ago

Patch is fine, was just worried it would flip again, but let's see.

comment:4 by Regina Obe <lr@…>, 17 months ago

Resolution: → fixed
Status: new → closed

In ad03e35/git:

Regress output fix from Tobias Bussmann
Closes #5470 for PostGIS 3.4.0

Note: See TracTickets for help on using tickets.