Opened 11 months ago
Closed 11 months ago
#5470 closed defect (fixed)
make installcheck for address_standardizer expects incorrectly formatted output
| Reported by: | tbussmann | Owned by: | robe |
|---|---|---|---|
| Priority: | medium | Milestone: | PostGIS 3.4.0 |
| Component: | pagc_address_parser | Version: | master |
| Keywords: | Cc: | strk |
Description
In [8cebf5d6/git] a new test for address_standardizer was added: test-debug_standardize_address. However it's expected output file was trimmed of trailing whitespace which results in make installcheck complaining on the differences.
Attached a trivial patch to fix this.
Attachments (1)
Change History (5)
by , 11 months ago
| Attachment: | postgis_check_address_standardizer.patch added |
|---|
comment:1 by , 11 months ago
| Cc: | added |
|---|
comment:2 by , 11 months ago
Yes, you remember correctly - a similar issue was fixed in [e6d6be31/git] (master) and [a5c0cb9/git] (3.3, see #5409) but for a different test test-standardize_address_1. Seeing this kind of issue repeatedly, looks like there is an issue with the editor or git config somewhere.
The patch attached to this ticket should fix it. Or do you prefer a PR?
Note:
See TracTickets
for help on using tickets.
Damn I thought we fixed this already. Maybe my editor config broke it on my last commit.
@strk remember how you fixed this last time?