Opened 11 months ago

Closed 11 months ago

#5459 closed defect (fixed)

When raster support is disabled, `make distclean` leaves Makefiles around

Reported by: strk Owned by: strk
Priority: medium Milestone: PostGIS 3.3.5
Component: build Version: 3.3.x
Keywords: Cc:

Description

Spotted on the MakeDist debbie's recipe: ​https://debbie.postgis.net/job/PostGIS_Make_Dist/label=debbie/4967/consoleFull

The tarball packages created by debbie contain Makefile files that shouldn't be there. This is because they are generated by ./configure but left behind by make distclean when raster is disabled.

Creating the package on my local machine, with raster enabled, correctly does not include those files.

Change History (7)

comment:1 by strk, 11 months ago

Component: postgis → build/upgrade/install
Owner: changed from pramsey to strk

comment:2 by strk, 11 months ago

Version: → 3.3.x

This was spotted packaging 3.3.4, I didn't check if this is already fixed in the master branch

comment:3 by strk, 11 months ago

The left behind files are:

  • extensions/address_standardizer/Makefile
  • extensions/postgis_raster/Makefile
  • raster/Makefile
  • raster/rt_pg/Makefile

The master branch has special code to cleanup sfcgal and raster when they are disabled, but there's nothing about address_standardized specifically

Last edited 11 months ago by strk (previous) (diff)

comment:4 by strk, 11 months ago

Milestone: PostGIS Packaging → PostGIS 3.3.5

comment:5 by Sandro Santilli <strk@…>, 11 months ago

In 86a8c4ab/git:

Do not create address_standardizer Makefile when not needed

References #5459

comment:6 by Sandro Santilli <strk@…>, 11 months ago

In cf199373/git:

Do not create address_standardizer Makefile when not needed

References #5459

comment:7 by Sandro Santilli <strk@…>, 11 months ago

Resolution: → fixed
Status: new → closed

In 40e326b/git:

Do not leave raster and sfcgal Makefiles behind when disabled

Closes #5459 in 3.3 branch (3.3.5dev)

Note: See TracTickets for help on using tickets.