Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#5441 closed defect (fixed)

winnie is trying to build translation docs

Reported by: robe Owned by: strk
Priority: blocker Milestone: PostGIS 3.4.0
Component: build Version: 3.3.x
Keywords: Cc:

Description

Looks like winnie's windows builds stopped on 7/3/2023.

Looks like it is failing on make install because she's trying to build translations.

I don't need docs built. Need to have a way to turn this off.

Example error: https://winnie.postgis.net/job/PostGIS_2_windows_PGVERSION_winnie/14464/console

She doesn't even have ability to build pdfs so why is pdf-clean even running

make[3]: Leaving directory '/projects/postgis/branches/3.4/doc/po/ru'
make[2]: Leaving directory '/projects/postgis/branches/3.4/doc/po/ru'
rm -f postgis*-en.pdf
rule=pdf-clean; \
for lang in it_IT pt_BR fr es pl ko_KR de ja ru; do \
    echo "Making $rule for language $lang..."; \
    make -C po/$lang local-$rule || exit 1; \
  done
Making pdf-clean for language it_IT...
make[2]: Entering directory '/projects/postgis/branches/3.4/doc/po/it_IT'
ln -sf ../../html .
ln: ./html: cannot overwrite directory
make[2]: *** [../Makefile.local:21: symlinks] Error 1
make[2]: Leaving directory '/projects/postgis/branches/3.4/doc/po/it_IT'
make[1]: *** [Makefile:347: pdf-clean-localized] Error 1
make[1]: Leaving directory '/projects/postgis/branches/3.4/doc'
make: *** [GNUmakefile:188: docs-clean] Error 2


E:\jenkins\postgis>E:

Change History (9)

comment:1 by robe, 10 months ago

I should add, I don't recall docs ever trying to be installed in previous versions. It really should be turned off by default. I expect most people will just download the docs from postgis.net or download.osgeo.org since we make them available as part of the release process. Packagers may want to build the docs themselves but I suspect most other people will not want to be bothered with it or have it slow down their install.

comment:2 by strk, 10 months ago

It's not trying to build them, it's cleaning them and the clean rule is failing to create the html symlink. I changed the symlink creation code in [eb952ac86bc68ef2e1035132f5e02ddeb1d9cfd2/git] to fix parallel build

I'll find another way

comment:3 by strk, 10 months ago

The other thing is that the message cannot overwrite directory should happen when the target is a real directory, if you give me access to the machine I'll check that out so I can also verify an eventual fix

comment:4 by Sandro Santilli <strk@…>, 10 months ago

In 6835c262/git:

Use less loops to clean (localize the localized clean rule)

References #5441

comment:5 by Sandro Santilli <strk@…>, 10 months ago

In 670a400/git:

Ensure winnie builds are always in a clean dir

References #5441

comment:6 by strk, 10 months ago

Do we need a separate ticket to deal with the fact those builds appear green even if failing ?

comment:7 by strk, 10 months ago

I'm lost in Jenkins, if you are able to drop a link here Regina we can tell if it's now fixed or not

comment:8 by Sandro Santilli <strk@…>, 10 months ago

Resolution: fixed
Status: newclosed

In 4a9b131/git:

Do remove and re-create symlinks

Works around mingw lack of symlinks support.
Should fix #5441

comment:9 by Sandro Santilli <strk@…>, 10 months ago

In ab511bf/git:

Use -rf to remove the html and xsl files under po/*

Worksaround lack of symlinks in windows

References #5441

Note: See TracTickets for help on using tickets.