Opened 17 months ago

Closed 17 months ago

Last modified 3 weeks ago

#5424 closed defect (fixed)

Use of remark tag preventing Z,M, curved support, SQL-MM attributes from showing in PDF

Reported by: robe Owned by: robe
Priority: medium Milestone: PostGIS 3.4.0
Component: documentation Version: master
Keywords: Cc:

Description

As a result of our new use of <remark> tag in docbook. Two changes have happened

  1. These text elements are now showing as yellow-marker highlights in the html docs
  1. These are completely left out in the PDF

I suspect because remark is intended to be used as perhaps notes to authors and corrections etc.

The other place it showed was index-aware tag. Since we don't use index aware tag for any xsl filtering, I took out the remark on that. That tags appears in some places in the docs, but usually within note tags, so looked extra funny with the double-yellow.

Change History (7)

comment:1 by robe, 17 months ago

Milestone: PostGIS 3.4.0PostGIS 3.5.0

comment:2 by strk, 17 months ago

The yellow color can be tweaked in html/style.css file. It looks like our new tag-files are the only ones using that tag so tweaking that color should not produce other unwanted changes.

As per the PDF, I've tried passing -P show.comments=1 as specified in https://dblatex.sourceforge.net/doc/manual/show.comments.html but it didn't seem to work.

The reason why I'm using <remark> is because we need tag to contain everything found in the tag_*.xml files for xml2pot to extract that content. Such tag ideally would have no other effect than grouping both the inlineimage and the paragraph to be translated, and produce no newline at its end. The remark tag seems to work for this. I've tried <para> (but introduces a neline) and I've tried <markup> (is not understood by xml2pot).

Tags that are supposedly supported by xlm2pot can be read here: https://github.com/KDE/poxml/blob/master/parser.cpp#L34

comment:3 by strk, 17 months ago

Another option would be using the <tip> tag, which is currently unused, and reques using the check.png file instead of the tip.png file to render that

comment:4 by strk, 17 months ago

I tried the <tip> idea, but it introduces a newline, which we don't want. Another option I've been thinking about is now that we have xsl-config.xml we could put all the text to be translated in that file and have a generator for each of those tag files that would use the xsl config text to generate them

comment:5 by Sandro Santilli <strk@…>, 17 months ago

Resolution: fixed
Status: newclosed

In 81e0db7/git:

Generate tag files from xsl-config.xml, fixing PDF output

Closes #5424

comment:6 by strk, 17 months ago

Milestone: PostGIS 3.5.0PostGIS 3.4.0

comment:7 by Paul Ramsey <pramsey@…>, 3 weeks ago

In e8d47bb4/git:

Round even grid/scale factors more precisely.
Closes #5424

Note: See TracTickets for help on using tickets.