debbie failing on tickets regress ST_Intersection PostGIS 3.1, PostGIS 3.2, GEOS 3.9, GEOS 3.10 branch

[robe]

Not sure what the deal is with this:

00:21:11  ./regress/core/tickets .. failed (diff expected obtained: /var/lib/jenkins/workspace/postgis/tmp/3_1_pg11w64/test_76_diff)
00:21:16 -----------------------------------------------------------------------------
00:21:16 --- ./regress/core/tickets_expected	2023-02-17 05:57:35.624052877 +0000
00:21:16 +++ /var/lib/jenkins/workspace/postgis/tmp/3_1_pg11w64/test_76_out	2023-06-19 04:21:16.127049595 +0000
00:21:16 @@ -327,10 +327,10 @@
00:21:16  #4011|ST_MultiLineString|MULTILINESTRING EMPTY|t|t
00:21:16  #4011|ST_GeometryCollection|MULTILINESTRING((0 0,0 0))|f|f
00:21:16  #4025|
00:21:16 -ERROR:  lwgeom_intersection_prec: GEOS Error: TopologyException: Input geom 0 is invalid: Self-intersection
00:21:16 -ERROR:  lwgeom_difference_prec: GEOS Error: TopologyException: Input geom 0 is invalid: Self-intersection
00:21:16 -ERROR:  lwgeom_symdifference_prec: GEOS Error: TopologyException: Input geom 0 is invalid: Self-intersection
00:21:16 -ERROR:  lwgeom_union_prec: GEOS Error: TopologyException: Input geom 0 is invalid: Self-intersection
00:21:16 +ERROR:  lwgeom_intersection_prec: GEOS Error: TopologyException: side location conflict at 5 5
00:21:16 +ERROR:  lwgeom_difference_prec: GEOS Error: TopologyException: side location conflict at 5 5
00:21:16 +ERROR:  lwgeom_symdifference_prec: GEOS Error: TopologyException: side location conflict at 5 5
00:21:16 +ERROR:  lwgeom_union_prec: GEOS Error: TopologyException: side location conflict at 5 5

the last run I did in May for 3.1.9 release passed and was also testing GEOS 3.9 (3.9.4dev).

I'm assuming something in GEOS 3.9 branch changed since this test hasn't changed since the 3.1.9 release.

Changes since PostGIS 3.1.9 release in geos 3.9 branch are:

​https://github.com/libgeos/geos/commit/8fd3b5f7127ab3e38fdc4621cf1aedcfbc165e57 (GEOSClipByRect)

and

​https://github.com/libgeos/geos/commit/d6f53e6c6b5da324aeb7d84a6044012710926a26 (Do not hide illegal argument exception in HeuristicOverlay )

The difference looks harmless, just a change in error messages to provide location of conflict

[robe]

I should add the same failure is happening on debbie's, PostGIS 3.2 branch which tests against GEOS: 3.10.6dev-CAPI-1.16.3.

but it's not failing on PostGIS 3.3 branch which is testing GEOS: 3.11.3dev-CAPI-1.17

[strk]

Those failing tests are referencing ticket #4037 which was calling for auto-fix of invalid polygons, and did expect a return from those calls, but later the behaviour changed referencing #4040 — all in all I'm ok with dropping the tests all togheter, and in general I think tests are better put in a file naming the operation rather than in "tickets.sql"

[Regina Obe <lr@…>]

In 9804dda/git:

Get rid of #4025 test
gives different error based on GEOS version
References #5404 for PostGIS 3.2.6

[Regina Obe <lr@…>]

In 59a8f9d/git:

Oops took out the wrong test.
Should be #4037 tests
References #5404 for PostGIS 3.2.6

[Regina Obe <lr@…>]

In 978c936/git:

Take out ticket regress test #4037
Gives different error notice on newer GEOS
Closes #5404 for PostGIS 3.1.10