postgis_restore.pl keeps FUNCTION _st_concavehull(geometry)

[strk]

I've taken a dump of a database loaded with non-extension core, topology and raster sql files from 3.0.9dev. Upon restoring it with postgis_restore.pl here's the KEEP list:

KEEP: FUNCTION _st_concavehull(geometry)
KEEP: TABLEDATA layer
KEEP: TABLEDATA topology
KEEP: SEQUENCE_SET topology_id_seq

This probably means we're missing a drop of the old signature. The postgis.sql.in file contains a DROP of the _st_concavehull(geometry) function, protected by a POSTGIS_GEOS_VERSION conditional, as for older geos we'll have a DIFFERENT signature, making upgrades harder to handle.

I think we should always provide the SAME signature, and internally complain if a parameter is passed that we cannot handle due to lack of GEOS.

[strk]

The problematic mixed signature was introduced in 3.3, version 3.2 is not affected, so retargetting to 3.3.4

[strk]

Documentation for user-facing functions in versions 3.2 and 3.3 report the same signature so this problem is only with internal function:

• ​https://postgis.net/manual-3.2/ST_ConcaveHull.html
• ​https://postgis.net/manual-3.3/ST_ConcaveHull.html

[Sandro Santilli <strk@…>]

In 5e05bc3e/git:

Have skip signature generator scan full postgis upgrade script

References #5396 in master branch (3.4.0dev)

[strk]

[5e05bc3e/git] effectively fixed this in the master (3.4.0dev) branch The 3.3 branch had that signature hard-coded in postgis_restore.pl.in so nothing to fix there.