Opened 23 months ago

Closed 23 months ago

#5345 closed defect (fixed)

Topology upgrade not supporting new CAST

Reported by: robe Owned by: strk
Priority: medium Milestone: PostGIS 3.4.0
Component: topology Version: master
Keywords: upgrade Cc:

Description (last modified by strk)

I tried creating a CAST for topology, but the topology_upgrade.sql script is not adding it

topology/Makefile.in has a line: 

#Generate upgrade script by stripping things that can't be reinstalled
3:33AM
and # TODO: use create_upgrade.pl

Change History (5)

comment:1 by strk, 23 months ago

Component: build/upgrade/install → topology
Description: modified (diff)
Status: new → assigned
Summary: upgrade script not supporting new CAST → Topology upgrade not supporting new CAST

comment:2 by strk, 23 months ago

Keywords: upgrade added

See also #3373 which is missing DOMAIN

comment:3 by Sandro Santilli <strk@…>, 23 months ago

Resolution: → fixed
Status: assigned → closed

In 3fbb9c7/git:

Generate topology upgrade via script

Closes #5345

comment:4 by strk, 23 months ago

Resolution: fixed
Status: closed → reopened

Reopening because while [3fbb9c75ae56c89e43fc4334c6c18e6102113869/git] does have topology_upgrade.sql generated by create_upgrade.pl that script is NOT supporting the syntax for CASTS used by topology yet. This is due to presence of schema qualification which fails matching the regexp used for casts:

/^create cast\s+\(\s*(\w+)\s+as\s+(\w+)\)/i)

Last edited 23 months ago by strk (previous) (diff)

comment:5 by Sandro Santilli <strk@…>, 23 months ago

Resolution: → fixed
Status: reopened → closed

In a4c05cd/git:

Support fully-qualified types and array types in CAST syntax

Closes #5345 for good this time

Note: See TracTickets for help on using tickets.