pgis_getopt() defines colliding opt* vars

[frankie]

See

https://buildd.debian.org/fetch.cgi?pkg=postgis;ver=1.5.1-3;arch=mips;stamp=1274527990

Specifically:

/usr/bin/make -C loader
make[2]: Entering directory `/build/buildd-postgis_1.5.1-3-mips-L5JyGx/postgis-1.5.1/loader'
mips-linux-gnu-gcc -Wall -g -O2  -fPIC -DPIC  -Wall -Wmissing-prototypes -I. -I/usr/include/postgresql/8.4/server -I/usr/include/postgresql/internal -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include/tcl8.5  -c -o stringbuffer.o stringbuffer.c
mips-linux-gnu-gcc -Wall -g -O2  -fPIC -DPIC  -Wall -Wmissing-prototypes -I. -I/usr/include/postgresql/8.4/server -I/usr/include/postgresql/internal -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include/tcl8.5  -c -o shpopen.o shpopen.c
mips-linux-gnu-gcc -Wall -g -O2  -fPIC -DPIC  -Wall -Wmissing-prototypes -I. -I/usr/include/postgresql/8.4/server -I/usr/include/postgresql/internal -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include/tcl8.5  -c -o dbfopen.o dbfopen.c
mips-linux-gnu-gcc -Wall -g -O2  -fPIC -DPIC  -Wall -Wmissing-prototypes -I. -I/usr/include/postgresql/8.4/server -I/usr/include/postgresql/internal -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include/tcl8.5  -c -o getopt.o getopt.c
mips-linux-gnu-gcc -Wall -g -O2  -fPIC -DPIC  -Wall -Wmissing-prototypes  -c shp2pgsql-core.c
mips-linux-gnu-gcc -Wall -g -O2  -fPIC -DPIC  -Wall -Wmissing-prototypes -I. -I/usr/include/postgresql/8.4/server -I/usr/include/postgresql/internal -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include/tcl8.5  -c -o shp2pgsql-cli.o shp2pgsql-cli.c
mips-linux-gnu-gcc -Wall -g -O2  -fPIC -DPIC  -Wall -Wmissing-prototypes stringbuffer.o shpopen.o dbfopen.o getopt.o shp2pgsql-core.o shp2pgsql-cli.o ../liblwgeom/liblwgeom.a -o shp2pgsql -lc -lm 
/usr/bin/ld: non-dynamic relocations refer to dynamic symbol optopt@@GLIBC_2.0
/usr/bin/ld: failed to set dynamic section sizes: Bad value
collect2: ld returned 1 exit status

It causes problems with mips(el) build failure, probably due to oddities in mips arch binutils, but anyway it is not a good programming style. Patching is trivial, anyway.

Cheers by your friendly neighborhood Debian packager.

[robe]

I think this one should be fixed before release since it causes packaging issues and according to the author is a trivial fix.

[pramsey]

I look forward to receiving that trivial fix.