Berries and debbie failing on installing pgtopo_import and pgtopo_export, --prefix not respected

[robe]

05:55:07 ---- Making install in loader
05:55:07 make[1]: Entering directory '/home/jenkins/workspace/PostGIS_Worker_Run/label/berrie/8a73d5ee4ea69f318deda4ad3f72ee4cb5f20371/loader'
05:55:07 /bin/bash ../libtool --mode=install /usr/bin/install -c pgsql2shp "/usr/local/bin/pgsql2shp"
05:55:07 libtool: install: /usr/bin/install -c pgsql2shp /usr/local/bin/pgsql2shp
05:55:07 /usr/bin/install: cannot create regular file '/usr/local/bin/pgsql2shp': Permission denied
05:55:07 make[1]: *** [Makefile:148: install] Error 1
05:55:07 make[1]: Leaving directory '/home/jenkins/workspace/PostGIS_Worker_Run/label/berrie/8a73d5ee4ea69f318deda4ad3f72ee4cb5f20371/loader'
05:55:07 make: *** [GNUmakefile:25: install] Error 1
05:55:08 Build step 'Execute shell' marked build as failure
05:55:13 Finished: FAILURE

I assume this is a result of this:

[8a73d5ee4e/git]

So the cis need to be changed to now use the prefix

[Regina Obe <lr@…>]

In 0415ccb6/git:

More cleanup of berrie64 script
Change berries to use —prefix so they don't install shp2pgsql/pgsql2shp
in system location
Closes #5269 for PostGIS 3.4.0

[strk]

I think you want to omit the /bin part from the —prefix (or you'd end up installing in bin/bin)

[strk]

Use —bindir if you only want to tweak the binaries installation

[robe]

I switched to using PGPATH no /bin. Debbie has always been without bin and it worked before. Why are they ignoring the —prefix now. I am also having same issue with winnie, except she doesn't error cause she has access to her /usr/share/bin folder. It's just the pgtopo_import and pgtopo_export going into the wrong folder not respecting her —prefix clause. It respects it in 3.3 branch.

The issue is not the shp2pgsql, but the pgtopo_import and pgtopo_export

04:57:57 /bin/sh ../libtool --mode=install /usr/bin/install -c loader/pgtopo_import "/bin/pgtopo_import"
04:57:57 libtool: install: /usr/bin/install -c loader/pgtopo_import /bin/pgtopo_import
04:57:57 /usr/bin/install: cannot create regular file '/bin/pgtopo_import': Permission denied
04:57:57 make[1]: *** [Makefile:181: install-importer] Error 1
04:57:57 make[1]: Leaving directory '/var/lib/jenkins/workspace/postgis/branches/3.4/topology'

[strk]

To recap: shp2pgsql and pgsql2shp install fine but pgtopo_import and pgtopo_export do not ? Can you grep bindir topology/Makefile loader/Makefile ?

[strk]

stable-3.3 branch does not have any bindir assigment in topology/Makefile.in while master branch does. maybe := would make a difference on line 84 of topology/Makefile.in

[Sandro Santilli <strk@…>]

In e09c095/git:

Honour —prefix for setting bindir in topology/loader

Should fix #5269