Opened 2 years ago
Closed 2 years ago
#5256 closed defect (fixed)
"3.4.0dev--:auto!" upgrade test not performed by bots
Reported by: | robe | Owned by: | strk |
---|---|---|---|
Priority: | medium | Milestone: | PostGIS 3.4.0 |
Component: | build | Version: | master |
Keywords: | Cc: |
Description
As noted in #5253, none of the ci bots showed red for the error #5253. I only stumbled on the issue when trying to upgrade my dev environment.
To fix I had put in a test specifically for current — auto! [b9439d2d0d7/git]
strk thinks this should not have been needed. I had a hard time reading this script so I may have missed where it is called.
My understanding is —auto uses the standard extension machinery
—auto! uses the postgis_extensions_upgrade() function
Change History (4)
comment:1 by , 2 years ago
comment:2 by , 2 years ago
Summary: | check_all_upgrades.sh does not test postgis_extensions_upgrade from same version to same version → "3.4.0dev--:auto!" upgrade test not performed by bots |
---|
Ok I renamed the ticket to "3.4.0dev--:auto!" upgrade test not performed by bots
as that's what I understand is happening.
I think we should have make installcheck
run that test, as it currently only tests the upgrade from _unpackaged_ and not from self-extension.
comment:3 by , 2 years ago
I've sent a fix to make installcheck
in https://gitlab.com/postgis/postgis/-/merge_requests/90
The
check_all_ugprades.sh
script never tested self-self upgrade becausemake
targets should be doing that already, specifically:make check
should be testing with —upgrade which does script-based upgrademake installcheck
should be testing with —extension from unpackaged, both via DDL and via postgis_extension_upgrade [ seemake installcheck-upgrade-byfunc
]From what I can see gitlab-ci is supposed to be running
make installcheck
so should do the same-same upgrade.Which path are we missing, exactly ? Same-same both being extension ? Better be specific about the *problem* (renaming this ticket to indicate the problem)