#5215 closed defect (fixed)
gitlab-ci is not checking installs in 2.5 branch
| Reported by: | strk | Owned by: | robe |
|---|---|---|---|
| Priority: | blocker | Milestone: | PostGIS 2.5.8 |
| Component: | QA/buildbots | Version: | 2.5.x -- EOL |
| Keywords: | Cc: |
Description (last modified by )
When using:
`
make installcheck RUNTESTFLAGS=-v
`
The RUNTESTFLAGS is fully set by user instead of being *appended_to*.
This means the internal --extension switch won't be used, defeating the purpose of the installcheck.
Note that this would work:
`
RUNTESTFLAGS=-v make installcheck
`
The gitlab-ci configuration in branch 2.5 is using the non-functional call, resulting in lack of install check and duplicated normal check.
This was fixed from 3.0 onward, see commit [ae5e5a8f816b70d82d43964bb81395c1b685ec29/git]
Change History (3)
comment:1 by , 2 years ago
| Description: | modified (diff) |
|---|---|
| Summary: | gitlab-ci is not checking installs for branches 3.0 and 2.5 → gitlab-ci is not checking installs in 2.5 branch |
comment:2 by , 2 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:3 by , 2 years ago
For the record: the master branch at time of writing (3.3.0rc1) correctly handles a the make installcheck RUNTESTFLASG=-v so at some point the code was fixed to not completely override internal flags.
I believe it happened with [155a4e664b51ed6742ca8adffbdc60f1059a9c30/git] which introduced the use of RUNTESTFLAGS_INTERNAL which didn't make it into 3.0 and 2.5 branches (but 3.0 already used in gitlab-ci config the working call)
In bc3e8648/git: