#5193 closed defect (fixed)

mixed qualification of pg_catalog arguments

Reported by: strk Owned by: pramsey
Priority: medium Milestone: PostGIS 3.3.0
Component: postgis Version: master
Keywords: Cc: robe


I stumbled upon this line in postgis.sql: ` postgis/postgis.sql.in:548:CREATE OR REPLACE FUNCTION _postgis_selectivity(tbl pg_catalog.regclass, att_name text, geom geometry, mode text default '2') `

and wondering why do we qualify "regclass" but not "text"

I don't know what's important to qualify but the inconsistency I don't understand.

NOTE: I found this out while trying to match the CREATE OR REPLACE FUNCTION lines in our SQL file to what's already present in the database, comparing against the output of pg_get_function_identity_arguments function which (for the record) NEVER qualifies pg_catalog, even if it's not explicitly in your search_path

Change History (3)

comment:1 by robe, 17 months ago

That was an oversight on my part.

comment:2 by robe, 17 months ago

Hmm there are a lot like this. I think I had started replacing and then decided it was too many so stopped. I'm just going to take this out to keep things consistent.

comment:3 by Regina Obe <lr@…>, 17 months ago

Resolution: fixed
Status: newclosed

In d6d8401e/git:

Remove overreplacement. Closes #5193 for PostGIS 3.3.0

Note: See TracTickets for help on using tickets.