postgis_extension_AddToSearchPath should take input as text instead of varchar, helpers should use CREATE FUNCTION

[robe]

This is a security change.

It is possible for a user to create a function postgis_extension_AddToSearchPath(text) in the same schema as the

postgis_extension_AddToSearchPath(varchar) we defined.

This could allow a rogue user to have their version of function run during extension create/updates instead of the one we ship.

Also as general best practice we should use CREATE FUNCTION instead of CREATE OR REPLACE FUNCTION. We can easily change for the helper functions since they are created as part of install and then dropped after.

[Regina Obe <lr@…>]

In c356da3/git:

Change signature of AddToSearchPath, references #5150

[Regina Obe <lr@…>]

In b175c26/git:

Numerous fixes to helper functions.
References #5150
References #5125
References #5155 for PostGIS 3.1.6

[Regina Obe <lr@…>]

In 7e6980e4/git:

References #5150 - Change signature of AddToSearchPath
References #5155, More schema qual fixes
for PostGIS 2.5.7

[Regina Obe <lr@…>]

In d5d3dfe/git:

Search path and schema qual changes. Closes #5150 Closes #5155 for PostGIS 3.0.6