st_dwithin(geography,geography,double precision) needs a REPLACE note and document change

[robe]

I ran into issues trying to upgrade a PG 9.6 2.4 database to PG 11 3.1.

It failed on trying to drop ST_DWithin(geography,geography, double precision)

 materialized view public.vw_mat.. depends on function st_dwithin(geography,geography,double precision)

There is no comment that this was even changed. But I bet it was changed to a) add argument names and or b) add the SUPPORT postgis_index_supportfn

which requires PostgreSQL 12 or higher

The code says - last change was 1.5.0.

At anyrate this should be documented in the docs and in the code. It should use the new REPLACE documentation syntax

[strk]

I'm not sure we handle adding argument names, should be tested

[strk]

by the way, NONE of our CIs test upgrades across PostgreSQL versions, to my knowledge

[strk]

The DROP of ST_DWithin(geography, geography, double precision) was added by Paul with commit [2f3e2783e7e1fa57a5a994e0c82d9784e94895b9/git] - referencing #4341 (SVN times)

[strk]

I fixed the upgrade part with ​https://git.osgeo.org/gitea/postgis/postgis/pulls/70 Regina see if you like it, and maybe you can do the documentation part?

[Sandro Santilli <strk@…>]

In ec98bd6/git:

Add support for upgrading in presence of views using deprecated ST_DWithin

References #5035 in master branch (3.3.0dev)

[Sandro Santilli <strk@…>]

In 690011b5/git:

Add support for upgrading in presence of views using deprecated ST_DWithin

References #5035 in 3.2 branch (3.2.1dev)

[Sandro Santilli <strk@…>]

In 002a55f/git:

Add support for upgrading in presence of views using deprecated ST_DWithin

Closes #5035 in 3.1 branch (3.1.5dev)

[strk]

For the record, the fix for this partially broken as a Replaces for text,text was added while the text,text signature is still around (defined in geography.sql) See #5494