liblwgeom builds with no warning flags by default

[strk]

I've spent a lot of time to find out I was passing the wrong format to lwdebug(), and I've realized the default build of liblwgeom happens with no -Wall (or any other -W flag). I think we want all warnings enabled by default, as it happens under postgis/

[strk]

The warning that would have saved me a lot of time should be -Wformat

[strk]

It looks like the default -Wall flag (and others) were intentionally removed with [cdd520d378efb2d6b0b3ced7de566107a2a5b4a2/git] by Raúl mentioning issue #4630

[strk]

Algunenano do you agree to re-add -Wall to CFLAGS ? I guess we used a DIFFERENT variable to avoid having duplicated flags when building the PostgreSQL-dependent code which already uses flags from PostgreSQL build

[Algunenano]

I think we want all warnings enabled by default, as it happens under postgis/

That's not correct. As you mentioned later, postgis/ gets any extra flags declared by postgresql, so your '-Wall' likely comes from Postgresql compilation.

Algunenano do you agree to re-add -Wall to CFLAGS ?

I'm not against it as long as it's added everywhere, that is, to all build files and not only to certain folders.

Have you considered setting up your environment variables to match your development requirements? For example, my CFLAGS look something like this:

-march=native -mtune=native -O3 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -Wall -Wextra -Wno-unused-parameter -g3 -gdwarf -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer

And whenever I build a project (Postgis or any other) I use those flags. I don't have to depend on whether autotools, cmake or whatever is used by the project, sets warnings or not, only how to pass my flags.

[strk]

I've re-enabled -Wall with [71e5d2cfce41904c6eb5c51091d3b8e3d1478b50/git]