getPoint2d_p_ro is redundant

[strk]

The getPoint2d_cp() function does the same thing with a cleaner user interface (more const correctness)

getPoint2d_cp is defined in liblwgeom/lwinline.h which is included by liblwgeom_internal.h

[strk]

The comment above the definition of getPoint2d_p_ro, which is in lwgeodetic.c, says:

/**
* This function can only be used on LWGEOM that is built on top of
* GSERIALIZED, otherwise alignment errors will ensue.
*/
int getPoint2d_p_ro(const POINTARRAY *pa, uint32_t n, POINT2D **point)

Is that true, Paul ? Doesn't sound correct to me ? How can you build a POINTARRAY which is not aligned ?

[strk]

Proposed change (drop of the redundant function): ​https://gitlab.com/postgis/postgis/-/merge_requests/53

[Sandro Santilli <strk@…>]

In b4f0beef/git:

Drop redundant getPoint2d_p_ro function

Closes #4965