Opened 3 months ago

Closed 3 months ago

#4927 closed defect (fixed)

PostgreSQL 14 compile failure with master

Reported by: robe Owned by: robe
Priority: blocker Milestone: PostGIS 3.1.3
Component: postgis Version: master
Keywords: pg14 Cc:

Description

PostgreSQL 14 can't compile against PostGIS head. Getting this error during configure.

20:58:15 make[1]: Entering directory '/var/lib/jenkins/workspace/postgis/branches/3.2/libpgcommon'
20:58:15 gcc -I../liblwgeom  -I/var/lib/jenkins/workspace/geos/rel-3.9w64/include   -I/usr/include/libxml2 -I/usr/include -I/usr/include/json-c  -DNDEBUG  -std=gnu99 -g -O2 -fno-math-errno -fno-signed-zeros -I/var/lib/jenkins/workspace/pg/rel/pg14w64/include/postgresql/server   -fPIC -DPIC  -c -o gserialized_gist.o gserialized_gist.c
20:58:16 gcc -I../liblwgeom  -I/var/lib/jenkins/workspace/geos/rel-3.9w64/include   -I/usr/include/libxml2 -I/usr/include -I/usr/include/json-c  -DNDEBUG  -std=gnu99 -g -O2 -fno-math-errno -fno-signed-zeros -I/var/lib/jenkins/workspace/pg/rel/pg14w64/include/postgresql/server   -fPIC -DPIC  -c -o lwgeom_transform.o lwgeom_transform.c
20:58:16 gcc -I../liblwgeom  -I/var/lib/jenkins/workspace/geos/rel-3.9w64/include   -I/usr/include/libxml2 -I/usr/include -I/usr/include/json-c  -DNDEBUG  -std=gnu99 -g -O2 -fno-math-errno -fno-signed-zeros -I/var/lib/jenkins/workspace/pg/rel/pg14w64/include/postgresql/server   -fPIC -DPIC  -c -o lwgeom_cache.o lwgeom_cache.c
20:58:17 gcc -I../liblwgeom  -I/var/lib/jenkins/workspace/geos/rel-3.9w64/include   -I/usr/include/libxml2 -I/usr/include -I/usr/include/json-c  -DNDEBUG  -std=gnu99 -g -O2 -fno-math-errno -fno-signed-zeros -I/var/lib/jenkins/workspace/pg/rel/pg14w64/include/postgresql/server   -fPIC -DPIC  -c -o lwgeom_pg.o lwgeom_pg.c
20:58:17 lwgeom_pg.c: In function ‘postgis_get_full_version_schema’:
20:58:17 lwgeom_pg.c:121:28: error: too few arguments to function ‘FuncnameGetCandidates’
20:58:17   121 |  FuncCandidateList clist = FuncnameGetCandidates(names, -1, NIL, false, false, false);
20:58:17       |                            ^~~~~~~~~~~~~~~~~~~~~
20:58:17 In file included from lwgeom_pg.c:32:
20:58:17 /var/lib/jenkins/workspace/pg/rel/pg14w64/include/postgresql/server/catalog/namespace.h:99:26: note: declared here
20:58:17    99 | extern FuncCandidateList FuncnameGetCandidates(List *names,
20:58:17       |                          ^~~~~~~~~~~~~~~~~~~~~
20:58:17 make[1]: *** [Makefile:64: lwgeom_pg.o] Error 1
20:58:17 make[1]: Leaving directory '/var/lib/jenkins/workspace/postgis/branches/3.2/libpgcommon'
20:58:17 make: *** [GNUmakefile:22: all] Error 1
20:58:17 Build step 'Execute shell' marked build as failure

Looks like this has been happening since June 10th. Unfortunately my PostgreSQL build logs only keep like the last 30 builds and a lot has been happening in PostgreSQL repo in the past 2 days.

Change History (5)

comment:1 Changed 3 months ago by robe

Keywords: pg14 added

comment:2 Changed 3 months ago by robe

Okay found smoking change in this commit - https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=e56bce5d43789cce95d099554ae9593ada92b3b7

FuncCandidateList
 FuncnameGetCandidates(List *names, int nargs, List *argnames,
                      bool expand_variadic, bool expand_defaults,
-                     bool missing_ok)
+                     bool include_out_arguments, bool missing_ok)
 {
    FuncCandidateList resultList = NULL;
    bool        any_special = false;
@@ -978,6 +986,7 @@ FuncnameGetCandidates(List *names, int nargs, List *argnames,
    {
        HeapTuple   proctup = &catlist->members[i]->tuple;
        Form_pg_proc procform = (Form_pg_proc) GETSTRUCT(proctup);
+       Oid        *proargtypes = procform->proargtypes.values;
        int         pronargs = procform->pronargs;
        int         effective_nargs;
        int         pathpos = 0;
@@ -1012,6 +1021,35 @@ FuncnameGetCandidates(List *names, int nargs, List *argnames,
                continue;       /* proc is not in search path */
        }

comment:3 Changed 3 months ago by robe

Owner: changed from pramsey to robe

comment:4 Changed 3 months ago by Regina Obe <lr@…>

In 296e1bfd/git:

Suggested change from Julien Rouhaud (rjuju) to fix PG14
references #4927 for PostGIS 3.2.0

comment:5 Changed 3 months ago by Regina Obe <lr@…>

Resolution: fixed
Status: newclosed

In 26544e6/git:

Fix PG14 compile FuncnameGetCandidates? closes #4927 for PostGIS 3.1.3

Note: See TracTickets for help on using tickets.