Opened 8 months ago

Closed 8 months ago

#4852 closed enhancement (fixed)

Remove ST_IsValid NOTICE output

Reported by: mdavis Owned by: pramsey
Priority: medium Milestone: PostGIS 3.2.0
Component: postgis Version: master
Keywords: Cc:

Description

ST_IsValid emits a NOTICE for invalid inputs. This can cause a huge volume of unwanted console output in some situations.

Now that ST_ValidReason is available, it would be good to eliminate the NOTICE output from ST_IsValid.

Change History (6)

comment:1 Changed 8 months ago by pramsey

Milestone: PostGIS 3.1.2PostGIS 3.2.0
Version: 2.5.xmaster

comment:2 Changed 8 months ago by dbaston

Should this just be handled in GEOS-land? Stop emitting the notice here? https://github.com/libgeos/geos/blob/master/capi/geos_ts_c.cpp#L689

comment:3 Changed 8 months ago by mdavis

Seems reasonable to remove this from GEOS.

comment:4 Changed 8 months ago by dbaston

Or, as this is appears to be the only NOTICE that GEOS emits, PostGIS could just not register a GEOS NOTICE handler.

comment:5 Changed 8 months ago by mdavis

Let's do both! NOTICEs are ugly and awkward in libraries.

Last edited 8 months ago by mdavis (previous) (diff)

comment:6 Changed 8 months ago by Paul Ramsey <pramsey@…>

Resolution: fixed
Status: newclosed

In 91e5c65/git:

Remove NOTICE when ST_IsValid finds an invalid geometry. Closes #4852

Note: See TracTickets for help on using tickets.