Opened 4 years ago

Closed 4 years ago

#4852 closed enhancement (fixed)

Remove ST_IsValid NOTICE output

Reported by: mdavis Owned by: pramsey
Priority: medium Milestone: PostGIS 3.2.0
Component: postgis Version: master
Keywords: Cc:

Description

ST_IsValid emits a NOTICE for invalid inputs. This can cause a huge volume of unwanted console output in some situations.

Now that ST_ValidReason is available, it would be good to eliminate the NOTICE output from ST_IsValid.

Change History (6)

comment:1 by pramsey, 4 years ago

Milestone: PostGIS 3.1.2 → PostGIS 3.2.0
Version: 2.5.x → master

comment:2 by dbaston, 4 years ago

Should this just be handled in GEOS-land? Stop emitting the notice here? ​https://github.com/libgeos/geos/blob/master/capi/geos_ts_c.cpp#L689

comment:3 by mdavis, 4 years ago

Seems reasonable to remove this from GEOS.

comment:4 by dbaston, 4 years ago

Or, as this is appears to be the only NOTICE that GEOS emits, PostGIS could just not register a GEOS NOTICE handler.

comment:5 by mdavis, 4 years ago

Let's do both! NOTICEs are ugly and awkward in libraries.

Last edited 4 years ago by mdavis (previous) (diff)

comment:6 by Paul Ramsey <pramsey@…>, 4 years ago

Resolution: → fixed
Status: new → closed

In 91e5c65/git:

Remove NOTICE when ST_IsValid finds an invalid geometry. Closes #4852

Note: See TracTickets for help on using tickets.