Opened 3 years ago

Closed 2 years ago

#4834 closed defect (fixed)

protobuf checking on berrie causing compile to fail

Reported by: robe Owned by: robe
Priority: medium Milestone: PostGIS 3.1.4
Component: buildbots Version: 3.1.x
Keywords: Cc:


Did something change recently with our protobuf checking.

I'm seeing this on berrie (Rasberry Pi 32-bit). She does not have protobuf installed and never has to my knowledge. Seeing this now both on berrie's 3.1 and 3.2 (master) runs

15:48:33 checking for PROTOBUFC... no
15:48:33 libprotobuf-c not found in pkg-config
15:48:33 checking protobuf-c/protobuf-c.h usability... no
15:48:33 checking protobuf-c/protobuf-c.h presence... no
15:48:33 checking for protobuf-c/protobuf-c.h... no
15:48:33 configure: error: unable to find protobuf-c/protobuf-c.h using CPPFLAGS. You can disable MVT and Geobuf support using --without-protobuf

Before this would just cause MVT to be disabled. Now as of January 15th it's failing as it's trying to compile with proto-buf.

But unfortunately some other stuff was going on with hardware so hard to pinpoint when this particular error started.

Last success was Jan 13th -

showed this:

04:23:11   PostGIS is now configured for aarch64-unknown-linux-gnu
04:23:11  -------------- Compiler Info ------------- 
04:23:11   C compiler:           gcc -std=gnu99 -g -O2 -fno-math-errno -fno-signed-zeros
04:23:11   CPPFLAGS:              -I/usr/include   -I/usr/include/libxml2  -I/usr/include/json-c  -DNDEBUG 
04:23:12   LDFLAGS:               -lm
04:23:12   SQL preprocessor:     /usr/bin/cpp -traditional-cpp -w -P
04:23:12  -------------- Additional Info ------------- 
04:23:12   Interrupt Tests:   DISABLED use: --with-interrupt-tests to enable
04:23:12  -------------- Dependencies -------------- 
04:23:12   GEOS config:          /usr/bin/geos-config
04:23:12   GEOS version:         3.7.1
04:23:12   GDAL config:          /usr/bin/gdal-config
04:23:12   GDAL version:         2.4.0
04:23:12   PostgreSQL config:    /home/jenkins/workspace/pg/label/berrie/rel/pg12w32/bin/pg_config
04:23:12   PostgreSQL version:   PostgreSQL 12.5
04:23:12   PROJ4 version:        52
04:23:12   Libxml2 config:       /usr/bin/xml2-config
04:23:12   Libxml2 version:      2.9.4
04:23:12   JSON-C support:       yes
04:23:12   protobuf support:     no
04:23:12   PCRE support:         yes
04:23:12   Perl:                 /usr/bin/perl
04:23:12  --------------- Extensions --------------- 
04:23:12   PostGIS Raster:                     enabled
04:23:12   PostGIS Topology:                   enabled
04:23:12   SFCGAL support:                     disabled
04:23:12   Address Standardizer support:       enabled
04:23:12  -------- Documentation Generation -------- 
04:23:12   xsltproc:             /usr/bin/xsltproc
04:23:12   xsl style sheets:     /usr/share/xml/docbook/stylesheet/docbook-xsl
04:23:12   dblatex:              
04:23:12   convert:              
04:23:12   mathml2.dtd:          /usr/share/xml/schema/w3c/mathml/dtd/mathml2.dtd

Change History (7)

comment:1 by Algunenano, 3 years ago

This was changed in 3.1 to stop people from unknowingly building without MVT and Geobuf support because if failed "silently" (I mean, nobody would see it among hundreds of lines of similar text).

You need to either have protobuf development files installed or explicitly disable it.

comment:2 by Algunenano, 3 years ago

I've been having at look at this and I have no idea why this is failing now. It was introduced several months ago and the script is using --without-protobuf so it shouldn't be checked.

$ cat ci/berrie/ | grep protobuf
./configure --with-pgconfig=${PGPATH}/bin/pg_config --without-protobuf

It was working until a few days ago and the first time it failed was

Previous failures in that CI seem unrelated to protobuf.

comment:3 by pramsey, 3 years ago

I can configure —without-protobuf in 3.1dev and it works fine. Configure completes, and reports "protobuf support: no".

comment:4 by pramsey, 2 years ago

Milestone: PostGIS

comment:5 by pramsey, 2 years ago

Milestone: 3.1.3PostGIS 3.1.3

Milestone renamed

comment:6 by robe, 2 years ago

Milestone: PostGIS 3.1.3PostGIS 3.1.4

In prep for 3.1.3 release

comment:7 by pramsey, 2 years ago

Resolution: fixed
Status: newclosed

Older versions of PostGIS had —without-protobuf broken, but that's been fixed recently, I'm going to close this and see if it comes back.

Note: See TracTickets for help on using tickets.