Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#4830 closed enhancement (fixed)

ValidateTopology does not check correctness of edge.left_face and edge.right_face for isolated edges

Reported by: strk Owned by: strk
Priority: medium Milestone: PostGIS 3.2.0
Component: topology Version: master
Keywords: Cc:

Description

Similar to lack of containing_face check for nods (#3233) the ValidateTopology also misses checking for left_face and right_face for isolated edges.

Change History (6)

comment:2 by strk, 4 years ago

Type: defectenhancement

comment:3 by Sandro Santilli <strk@…>, 4 years ago

Resolution: fixed
Status: newclosed

In d138985/git:

Check isolated edges are covered by their left-right faces

Updates existing tests accordingly.
Includes NEWS item.

Closes #4830

comment:4 by strk, 4 years ago

Resolution: fixed
Status: closedreopened

The fix still misses the case of isolated edge advertised to be in the universal face.

comment:5 by Sandro Santilli <strk@…>, 4 years ago

Resolution: fixed
Status: reopenedclosed

In ac60803/git:

Enhance test for topology edge side faces

  • Also check non-isolated ones
  • Catch universal face containment (only in non-boundary case)

Closes #4830 again

Includes more testcases and updates pre-existing one expectance.

The only missing check now is for dangling edges advertising
the universal face on only ONE side. We cannot easily check
this becase we'd expect such edge to be only contaied by a face
and it will be, even if both sides are in the _same_ face.
This case can only be determined by edge-linking checking
(references #3042)

comment:6 by Sandro Santilli <strk@…>, 3 years ago

In e0da8d5/git:

Rewrite test for hole containment to really focus on that check

References #4830

Note: See TracTickets for help on using tickets.