Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4810 closed defect (fixed)

upgrade tests failing on gml test and add NEWS

Reported by: robe Owned by: pramsey
Priority: blocker Milestone: PostGIS 3.1.0
Component: postgis Version: master
Keywords: Cc:

Description (last modified by robe)

Looks like the test introduced in [4cc9d7adb122726047646648bd75e2972cd6c7b4/git]

Broke upgrade tests as dronie has been failing since

 ./core/in_gml .. failed (diff expected obtained: /tmp/pgis_reg/test_20_diff)
-----------------------------------------------------------------------------
221.OBT: ERROR:  unknown spatial reference system
221.EXP: srs_21|SRID=4979;POINT(2 49 3)
222.OBT: ERROR:  unknown spatial reference system
222.EXP: srs_22|SRID=4985;POINT(2 49)
223.OBT: ERROR:  unknown spatial reference system
223.EXP: srs_23|SRID=8857;POINT(1 2)
224.OBT: ERROR:  unknown spatial reference system
224.EXP: srs_24|SRID=8360;POINT(2 49 3)
225.OBT: ERROR:  unknown spatial reference system
225.EXP: srs_25|SRID=8433;POINT(1 2)
-----------------------------------------------------------------------------

I should also mention I do not see a NEWS notice for the GML fix. that should be put in place as well.

Change History (9)

comment:1 by robe, 3 years ago

Description: modified (diff)
Summary: upgrade tests failing on gml testupgrade tests failing on gml test and add NEWS

comment:2 by robe, 3 years ago

The test is failing testing after upgrading from PostGIS 2.5.5 to 3.1.0dev

I think we do just 3.1.0 to 3.1.0 on the other bots. I think dronie is the only bot that currently tests true upgrades.

I did a check on spatial_ref_sys on 2.5 branch - https://git.osgeo.org/gitea/postgis/postgis/src/branch/stable-2.5/spatial_ref_sys.sql

and don't see these entries in them so I think they came after 2.5 release

comment:3 by pramsey, 3 years ago

Resolution: fixed
Status: newclosed

comment:4 by robe, 3 years ago

Resolution: fixed
Status: closedreopened

better but still failing:

 ./core/in_geohash .. ok in 25 ms
 ./core/in_gml .. failed (diff expected obtained: /tmp/pgis_reg/test_20_diff)
-----------------------------------------------------------------------------
223.OBT: ERROR:  unknown spatial reference system
223.EXP: srs_23|SRID=8857;POINT(1 2)
-----------------------------------------------------------------------------
 failed (PostGIS object count pre-test (5761) != post-test (5757))

comment:5 by Paul Ramsey <pramsey@…>, 3 years ago

Resolution: fixed
Status: reopenedclosed

In 76a849ed/git:

Add EPSG:8857 to set of missing SRS for GML test, Closes #4810w

comment:6 by Regina Obe <lr@…>, 3 years ago

In b5b5c30/git:

Try to fix dronie upgrade issue. References #4810

comment:7 by Regina Obe <lr@…>, 3 years ago

In 3d0f1ea/git:

Do fake ids and fake outputs to fix 2.5.5 upgrade tests references #4810

comment:8 by Regina Obe <lr@…>, 3 years ago

In f7ab9d6/git:

Do fake srid for EPSG:2393 to fix 2.1.9 upgrade tests references #4810

comment:9 by Regina Obe <lr@…>, 3 years ago

In 9b6e054/git:

include srtext for srid for EPSG:2393 and put in logic to delete to fix 2.1.9 upgrade tests references #4810

Note: See TracTickets for help on using tickets.