make installcheck against Pg13 fails

[pramsey]

Upgrade path: unpackaged --> 3.1.0dev!
PATH is /opt/pgsql/13/bin:/opt/pgsql/13/bin:/Users/pramsey/google-cloud-sdk/bin:/Users/pramsey/.cargo/bin:/Library/Frameworks/Python.framework/Versions/3.6/bin:/opt/pgsql/13/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/go/bin:/usr/local/go/bin:/Users/pramsey/Code/go/bin:/opt/local/bin:/opt/vagrant/bin
Checking for shp2pgsql ... found
Checking for pgsql2shp ... found
TMPDIR is /tmp/pgis_reg
Creating database 'postgis_reg' 
Loading unpackaged components from /Users/pramsey/Code/postgis-git/regress/00-regress-install/share/contrib/postgis
Loading PostGIS into 'postgis_reg' 
  Upgrading from postgis 3.1.0dev
Upgrading PostGIS in 'postgis_reg' using: SELECT postgis_extensions_upgrade()
 failed (Error encountered altering EXTENSION POSTGIS: /tmp/pgis_reg/regress_log)
Died at ../run_test.pl line 1646.
make[3]: *** [check] Error 1

Contents of /tmp/pgis_reg/regress_log

NOTICE:  Packaging extension postgis
ERROR:  CREATE EXTENSION ... FROM is no longer supported
LINE 1: CREATE EXTENSION postgis FROM unpackaged;
                                 ^
QUERY:  CREATE EXTENSION postgis FROM unpackaged;
CONTEXT:  PL/pgSQL function postgis_extensions_upgrade() line 57 at EXECUTE

If the upgrade path in Pg13 no longer involved unpackaged upgrade we should take this test out. If this is still a problem in general (upgrade on pg13) it seems like we have a big blocker.

[robe]

Isn't this already fixed by strk's recent commit? Haven't been having issues doing upgrade since his hack change in #4643. Closing this out. Feel free to open if you are still having issues.