Opened 4 months ago

Last modified 2 months ago

#4662 reopened defect

[raster] Fully qualify postgis types in SPI_execute calls

Reported by: Algunenano Owned by: Bborie Park
Priority: medium Milestone: PostGIS 2.4.9
Component: raster Version: 2.4.x
Keywords: Cc:

Description

Related to https://trac.osgeo.org/postgis/ticket/4661

There are multiple instances where raster SPI_calls do not schem qualify internal objects (Postgis functions, spatial_ref_sys and so on) so it might fail to find it if the schema holding them is not in the search_path (usually when the function is not installed in public or being used through FDW).

Change History (4)

comment:1 Changed 3 months ago by robe

Milestone: PostGIS 2.3.11PostGIS 2.4.9

I think this change is too invasive to make for the last release of PostGIS 2.3 so going to push to a future PostGIS 2.4.

comment:2 Changed 3 months ago by robe

Milestone: PostGIS 2.4.9PostGIS 2.3.11
Resolution: wontfix
Status: newclosed

Actually looks like this has already been done for 2.4, so I'm just going to close this out as won't fix.

comment:3 Changed 3 months ago by Algunenano

Milestone: PostGIS 2.3.11PostGIS 2.4.9
Resolution: wontfix
Status: closedreopened
Version: 2.3.x2.4.x

There are still at least 2 issues still in raster code:

  • rtpg_internal.c is using spatial_ref_sys.
  • rtpg_statistics.c is calling _st_summarystats multiple times without the schema.

These 2 inner calls will fail if the Postgis functions are not available in the search_path, which might happen if you've moved the extension of always if you are calling them through FDW (where only pg_temp is in the search_path).

comment:4 Changed 2 months ago by robe

worth fixing? Wanted to release 2.4 this Friday.

Note: See TracTickets for help on using tickets.