[raster] Fully qualify postgis types in SPI_execute calls

[Algunenano]

Related to ​https://trac.osgeo.org/postgis/ticket/4661

There are multiple instances where raster SPI_calls do not schem qualify internal objects (Postgis functions, spatial_ref_sys and so on) so it might fail to find it if the schema holding them is not in the search_path (usually when the function is not installed in public or being used through FDW).

[robe]

I think this change is too invasive to make for the last release of PostGIS 2.3 so going to push to a future PostGIS 2.4.

[robe]

Actually looks like this has already been done for 2.4, so I'm just going to close this out as won't fix.

[Algunenano]

There are still at least 2 issues still in raster code:

• rtpg_internal.c is using spatial_ref_sys.
• rtpg_statistics.c is calling _st_summarystats multiple times without the schema.

These 2 inner calls will fail if the Postgis functions are not available in the search_path, which might happen if you've moved the extension of always if you are calling them through FDW (where only pg_temp is in the search_path).

[robe]

worth fixing? Wanted to release 2.4 this Friday.

[pramsey]

Going to just leave this outstanding until an operational issue gets reported.

[strk]

Isn't this actually a security issue ?

[robe]

Not really because all the functions we have that call into our spis are security invoker and they don't get called during install.