Opened 9 months ago

Closed 6 months ago

#4620 closed enhancement (fixed)

Review and update wagyu to 0.5.0

Reported by: Algunenano Owned by: Algunenano
Priority: medium Milestone: PostGIS 3.1.0
Component: postgis Version: master
Keywords: Cc:

Description

Wagyu 0.5.0 has been released https://github.com/mapbox/wagyu/releases/tag/0.5.0

The plan is to review the differences (should be only the improvements in floating point comparison), performance and update our bundled code.

Attachments (3)

before.png (5.8 KB) - added by Algunenano 6 months ago.
Wagyu 0.4.3
after.png (5.5 KB) - added by Algunenano 6 months ago.
Wagyu 0.5.0
wagyu_043_vs_wagyu_050.pdf (107.4 KB) - added by Algunenano 6 months ago.
Wagyu comparison

Download all attachments as: .zip

Change History (7)

Changed 6 months ago by Algunenano

Attachment: before.png added

Wagyu 0.4.3

Changed 6 months ago by Algunenano

Attachment: after.png added

Wagyu 0.5.0

comment:1 Changed 6 months ago by Algunenano

0.5.0 Changelog:

Fixed various issues associated with floating point data and comparisions of numbers. This in effect solves some weird intersection bugs and situations where the bounds are not properly sorted. This can result in a variety of different crashes and bad results in the final output in very rare situations.

There are some minor visual differences (example in the attached geometries).

I'm testing how it behaves in terms of performance.

Changed 6 months ago by Algunenano

Attachment: wagyu_043_vs_wagyu_050.pdf added

Wagyu comparison

comment:2 Changed 6 months ago by Algunenano

Wagyu 0.5.0 seems slightly faster in some cases (up to 1.10x as fast).

It seems too big of a change to attribute it to the variance in the base machine (my development PC, with multithreading, dynamic frequency scaling and so on). I'm more inclined to attribute it to the removal of std::fabs calls in the floating point comparisons.

comment:4 Changed 6 months ago by Raúl Marín <git@…>

Resolution: fixed
Status: assignedclosed

In 9e5df19e/git:

Update wagyu to 0.5.0

Closes https://github.com/postgis/postgis/pull/563
Closes #4620

Note: See TracTickets for help on using tickets.