windows regress failing on ST_TileEnvelope

[robe]

Both winnie and my windows regress are failing

 quantize_coordinates .. ok in 358 ms
 regress .. failed (diff expected obtained: /projects/postgis/tmp/3.1.0dev_pg12_geos3.8.0_gdal2.4.3w64/test_68_diff)
-----------------------------------------------------------------------------
--- regress_expected	2019-12-11 21:02:17.744362700 -0500
+++ /projects/postgis/tmp/3.1.0dev_pg12_geos3.8.0_gdal2.4.3w64/test_68_out	2019-12-11 21:22:52.072177300 -0500
@@ -210,7 +210,7 @@
 ERROR:  ST_TileEnvelope: Margin must not be less than -50%, margin=-0.510000
 241|SRID=3857;POLYGON((-4007502 -4007502,-4007502 4007502,4007502 4007502,4007502 -4007502,-4007502 -4007502))
 250|SRID=3857;POLYGON((-8296781.484375 4852834.453125,-8296781.484375 4891970.21484375,-8257645.72265625 4891970.21484375,-8257645.72265625 4852834.453125,-8296781.484375 4852834.453125))
-251|SRID=3857;POLYGON((-8300695.06054688 4848920.87695312,-8300695.06054688 4895883.79101562,-8253732.14648438 4895883.79101562,-8253732.14648438 4848920.87695312,-8300695.06054688 4848920.87695312))
-252|SRID=3857;POLYGON((-8316349.36523438 4833266.57226562,-8316349.36523438 4911538.09570312,-8238077.84179688 4911538.09570312,-8238077.84179688 4833266.57226562,-8316349.36523438 4833266.57226562))
+251|SRID=3857;POLYGON((-8300695.06054688 4848920.87695313,-8300695.06054688 4895883.79101563,-8253732.14648438 4895883.79101563,-8253732.14648438 4848920.87695313,-8300695.06054688 4848920.87695313))
+252|SRID=3857;POLYGON((-8316349.36523438 4833266.57226563,-8316349.36523438 4911538.09570313,-8238077.84179688 4911538.09570313,-8238077.84179688 4833266.57226563,-8316349.36523438 4833266.57226563))
 253|SRID=3857;POLYGON((-8375053.0078125 4774562.9296875,-8375053.0078125 4970241.73828125,-8179374.19921875 4970241.73828125,-8179374.19921875 4774562.9296875,-8375053.0078125 4774562.9296875))
-254|SRID=3857;POLYGON((-8285040.75585938 4864575.18164062,-8285040.75585938 4880229.48632812,-8269386.45117188 4880229.48632812,-8269386.45117188 4864575.18164062,-8285040.75585938 4864575.18164062))
+254|SRID=3857;POLYGON((-8285040.75585938 4864575.18164063,-8285040.75585938 4880229.48632813,-8269386.45117188 4880229.48632813,-8269386.45117188 4864575.18164063,-8285040.75585938 4864575.18164063))
-----------------------------------------------------------------------------

​https://winnie.postgis.net:444/job/PostGIS_EDB_Regress_winnie/10144/console

[Algunenano]

Let's wait and see if addressing #4600 fixes this too.

[Raúl Marín <git@…>]

In 939c306/git:

ST_TileEnvelope: Improve precision by calculating the input bbox

References #4600
References #4602

Closes ​https://github.com/postgis/postgis/pull/522

[Algunenano]

Seems to be fixed with the improved bbox precision: ​https://winnie.postgis.net:444/job/PostGIS_EDB_Regress_winnie/10146/console

 quantize_coordinates .. ok in 299 ms
 regress .. ok in 613 ms

But the build is failing because of issues that were there before:

../loader/Point ........ failed (dumper geog test: dumping loaded table: /projects/postgis/tmp/3.1.0dev_pg12_geos3.8.0_gdal2.4.3w64/dumper.err)
-----------------------------------------------------------------------------
Initializing... 
Done (postgis major version: 3).
Output shape: Point
Dumping: XError in psSHP->sHooks.FWrite() while writing object of 28 bytes to .shp file: No error
Error writing shape 0
-----------------------------------------------------------------------------

I'm closing this ticket and I'll open a new one for that issue.