Opened 5 years ago

Closed 5 years ago

#4531 closed defect (fixed)

extensions/postgis/sql/postgis--unpackaged--<current>.sql dirty builds

Reported by: strk Owned by: pramsey
Priority: high Milestone: PostGIS 3.0.0
Component: postgis Version: master
Keywords: Cc:

Description

I have an old revision in my extensions/postgis/sql/postgis--unpackaged--3.0.0rc2dev.sql file, and even if that file gets _removed_ by make clean it gets back with the old revision upon running make again.

It seems due to postgis_upgrade_for_extension.sql.in not being removed by make clean and keeping the old revision around.

Change History (2)

comment:1 by strk, 5 years ago

It turns out that:

  1. make clean does not remove extensions/postgis/sql/postgis_upgrade_for_extension.sql.in
  2. make -C extensions/postgis sql/postgis_upgrade_for_extension.sql.in does not re-generate that file when it exists, even if the file it depends upon (sql/postgis_for_extension.sql) is not present.
  3. Calling make -C extensions/postgis sql/postgis_for_extension.sql creates the source file and unleashes the power of make sql/postgis_upgrade_for_extension.sql.in

Pretty confusing, isn't it ?

comment:2 by strk, 5 years ago

Resolution: → fixed
Status: new → closed

In 17890:

Make sure "make clean" really cleans what's created by "make"

Fixes #4531 and simplifies a little bit those Makefiles

Note: See TracTickets for help on using tickets.