Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#4521 closed defect (fixed)

ERROR: cannot change name of input parameter "pretty_print"

Reported by: strk Owned by: pramsey
Priority: blocker Milestone: PostGIS 3.0.0
Component: postgis Version: master
Keywords: Cc: Algunenano

Description

Cannot upgrade, from 3.0.0alpha3dev:

strk=# select postgis_full_version();
-[ RECORD 1 ]--------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
postgis_full_version | POSTGIS="3.0.0alpha5dev r17751" [EXTENSION] PGSQL="96" GEOS="3.8.0dev-CAPI-1.12.0 " SFCGAL="1.3.6" PROJ="Rel. 4.9.3, 15 August 2016" GDAL="GDAL 2.3.0dev, released 2017/99/99" LIBXML="2.9.4" LIBJSON="0.12.1" LIBPROTOBUF="1.2.1" WAGYU="0.4.3 (Internal)" (core procs from "3.0.0alpha3dev r17535" need upgrade) TOPOLOGY (topology procs from "3.0.0alpha5dev r17729" need upgrade) [UNPACKAGED!] RASTER (raster procs from "3.0.0alpha3dev r17535" need upgrade) (sfcgal procs from "3.0.0alpha3dev r17535" need upgrade)

strk=# select postgis_extensions_upgrade();
ERROR:  cannot change name of input parameter "pretty_print"
HINT:  Use DROP FUNCTION st_asgeojson(record,text,integer,boolean) first.
CONTEXT:  SQL statement "ALTER EXTENSION postgis UPDATE TO "3.0.0alpha5dev";"
PL/pgSQL function postgis_extensions_upgrade() line 59 at EXECUTE

Change History (9)

comment:1 by robe, 4 years ago

Priority: mediumblocker

comment:2 by pramsey, 4 years ago

Not an issue for upgrade from release versions, since the function in question did not exist prior to 3.0.

I do not consider a blocker for that reason.

comment:3 by pramsey, 4 years ago

In 17879:

Try and be a little broader in dropping temporary old signature
References #4521

comment:4 by pramsey, 4 years ago

Also, I cannot replicate ¯\_(ツ)_/¯

comment:5 by strk, 4 years ago

The error message says what it wants to be dropped, as an HINT:

HINT: Use DROP FUNCTION st_asgeojson(record,text,integer,boolean) first.

Doesn't look like changeset r17879 fixed it. Maybe _postgis_drop_funcion_if_needed fails to figure out this is _needed_ in this case

Does the function only look at parameter _names_ and not _types_ ?

comment:6 by strk, 4 years ago

Cc: Algunenano added

comment:7 by strk, 4 years ago

Resolution: duplicate
Status: newclosed

I just noticed this is a duplicate of #4483, which results closed. I'll reopen that one

comment:8 by Sandro Santilli <strk@…>, 4 years ago

Resolution: duplicatefixed

In 1bbc4cc/git:

Revert "Try and be a little broader in dropping temporary old signature"

This reverts commit 548f6d1f953df7b56e69abbbdff72e33dcfdcff2.

Fixes #4483 and #4521 as far as I can tell

comment:9 by Sandro Santilli <strk@…>, 4 years ago

In 98e3e25/git:

Revert "Try and be a little broader in dropping temporary old signature"

This reverts commit 548f6d1f953df7b56e69abbbdff72e33dcfdcff2.

Fixes #4483 and #4521 as far as I can tell, in the stable-3.0 branch

Note: See TracTickets for help on using tickets.