Dependency on xsltproc is critical to produce postgis.control

[evgen]

I tried to build posgis-3.0 commit(a6bb23c883c317a50eed9a22ac2faf178c8fe90a) from sources.

./configure allowed to build postgis without xsltproc. See output below. Then make -j compiled everything successfully without issues. And sudo make install installed it without single warning. However alter extension postgis update; returned an error: ERROR: could not open extension control file "/usr/share/postgresql/10/extension/postgis.control": No such file or directory

When I installed xsltproc, launched configure, make, sudo make install again - postgis.control appears in place along with all required sql files.

./configure output without xsltproc:

PostGIS is now configured for x86_64-pc-linux-gnu

-------------- Compiler Info ------------- 
  C compiler:           gcc -std=gnu99 -g -O2 -fno-math-errno -fno-signed-zeros
  CPPFLAGS:              -I/usr/include   -I/usr/include/libxml2  -I/usr/include/json-c  
  SQL preprocessor:     /usr/bin/cpp -traditional-cpp -w -P

 -------------- Additional Info ------------- 
  Interrupt Tests:   DISABLED use: --with-interrupt-tests to enable

 -------------- Dependencies -------------- 
  GEOS config:          /usr/bin/geos-config
  GEOS version:         3.6.2
  GDAL config:          /usr/bin/gdal-config
  GDAL version:         2.2.3
  PostgreSQL config:    /usr/bin/pg_config
  PostgreSQL version:   PostgreSQL 10.10 (Ubuntu 10.10-0ubuntu0.18.04.1)
  PROJ4 version:        49
  Libxml2 config:       /usr/bin/xml2-config
  Libxml2 version:      2.9.4
  JSON-C support:       yes
  protobuf-c support:   no
  PCRE support:         yes
  Perl:                 /usr/bin/perl
  Wagyu:                no

 --------------- Extensions --------------- 
  PostGIS Raster:                     enabled
  PostGIS Topology:                   enabled
  SFCGAL support:                     disabled
  Address Standardizer support:       enabled

 -------- Documentation Generation -------- 
  xsltproc:             
  xsl style sheets:     
  dblatex:              
  convert:              
  mathml2.dtd:          http://www.w3.org/Math/DTD/mathml2/mathml2.dtd

configure: WARNING:  --------- GEOS VERSION WARNING ------------ 
configure: WARNING:   You are building against GEOS 3.6.2.
configure: WARNING: 
configure: WARNING:   To take advantage of _all_ the features of 
configure: WARNING:   PostGIS, GEOS 3.7.0 or higher is required.
configure: WARNING: 
configure: WARNING:   For _most_ features, GEOS 3.6.0 is enough.
configure: WARNING: 
configure: WARNING:   We recommend GEOS 3.7.0 or higher
configure: WARNING: 
configure: WARNING:   You can download the latest versions from 
configure: WARNING:   http://geos.osgeo.org/ 
configure: WARNING:

[robe]

It's only critical if you are building from svn or git. If you build from tarball, the comments are already generated, so you shouldn't need xsltproc.

Were you building from tarball or one of our repos?

This has come up before but maybe it was closed.

[evgen]

Replying to robe:

It's only critical if you are building from svn or git. If you build from tarball, the comments are already generated, so you shouldn't need xsltproc.

Were you building from tarball or one of our repos?

This has come up before but maybe it was closed.

I've build it from git repo.

[pramsey]

As a larger conversation, the utility of the SQL comments, balanced against the build complexity of having our code depend on our docs, I'd actually be happy to drop the comments. I don't believe they offer actual value in use: people use the web, not the database browser, for doco.