Opened 9 months ago

Closed 3 months ago

#4501 closed defect (wontfix)

postgis_tiger_geocoder extension needs superuser=false

Reported by: robe Owned by: robe
Priority: blocker Milestone: PostGIS 2.5.5
Component: tiger geocoder Version: 2.5.x
Keywords: Cc:

Description

I had assumed that extensions could be installed by non-superusers if they are pure sql/plpsql. evidentally in extension control file it also needs to be marked as such as noted by RhodiumToad? on IRC

00:30:15	robe2:	RhodiumToad but if postgis_tiger_geocoder is all plpgsql shouldn't that be allowed?
00:30:59	RhodiumToad:	... is it?
00:32:32	RhodiumToad:	the extension control file is responsible for having superuser=false if the extension is successfully installable by non-superusers
00:37:23	robe2:	yes it's all sql and plpgsql
00:38:24	robe2:	it relies on PostGIS but it has no C functions just uses the postgis geometry type
00:45:56	localhorse:	RhodiumToad, robe2: is heroku's whitelist visible somewhere?
00:56:21	RhodiumToad:	robe2: does it have a superuser=false declaration in the control file?
00:56:30	RhodiumToad:	localhorse: presumably in their docs
01:07:45	robe2:	no
01:07:50	robe2:	should I add one?
01:08:32	RhodiumToad:	if all the commands in the extension sql file can be executed by a non-superuser, even in the upgrade case (i.e. no hacking on system catalogs allowed), then yes
01:08:45	robe2:	okay thanks :)
01:08:46	RhodiumToad:	if not then no
01:08:58	RhodiumToad:	test it out of course
01:09:19	robe2:	yah no crazy hacking of catalog files is done everything thru just sql or pgsql and no direct update of system catalogs

Change History (5)

comment:1 Changed 9 months ago by strk

I thought I'd mention that "postgis_topology" used to be plpgsql only until PostGIS version 2.2.0. How could such an upgrade be dealth with in extension-land ?

comment:2 Changed 9 months ago by robe

Summary: postgis_tiger_geocoder extension needs super_user=falsepostgis_tiger_geocoder extension needs superuser=false

comment:3 Changed 9 months ago by robe

In 17806:

Mark tiger geocoder as superuser safe since it only has plpgsql/sql and no c lib
References #4501 for PostGIS 3.0

comment:4 Changed 3 months ago by pramsey

Milestone: PostGIS 2.5.4PostGIS 2.5.5

comment:5 Changed 3 months ago by pramsey

Resolution: wontfix
Status: newclosed

I don't think this should be back-ported.

Note: See TracTickets for help on using tickets.