Opened 5 months ago

Closed 5 months ago

#4488 closed defect (fixed)

pg_restore: ERROR: relation "topology_id_seq" already exists

Reported by: strk Owned by: strk
Priority: blocker Milestone: PostGIS 3.0.0
Component: topology Version: master
Keywords: Cc:

Description

Spotted in https://gitlab.com/postgis/postgis/-/jobs/277875966

... it looks like we're not properly marking a sequence as being part of the extension ...

Probably since forever.

Change History (8)

comment:1 Changed 5 months ago by strk

#2503 may be related to this

comment:2 Changed 5 months ago by strk

To reproduce:

cd topology/test
../../regress/run_test.pl --topology -v --dumprestore --extension \
     --upgrade-path unpackaged--3.0.0alpha5dev \
     regress/legacy_validate.sql

comment:3 Changed 5 months ago by strk

The comments above the target rule for sql/topology_upgrade.sql in extensions/postgis_topology/Makefile.in say they are supposed to do many things which aren't really done, like removing the CREATE TABLE parts

comment:4 Changed 5 months ago by strk

I see there's no config_dump call in either postgis/sql/postgis--unpackaged--3.0.0alpha5dev.sql or postgis_topology/sql/postgis_topology--unpackaged--3.0.0alpha5dev.sql so this might be a problem for core as well ?

comment:5 Changed 5 months ago by strk

In 17759:

Add support for extension sequences in create_unpackaged.pl

Should fix topology dump-restore
References #4488

comment:6 Changed 5 months ago by strk

I think this is fixed with r17759 (improved create_unpackaged.pl) Will wait for confirmation by gitlab-ci though

comment:8 Changed 5 months ago by strk

Resolution: fixed
Status: newclosed

Gitlab-CI confirms, yay!

Note: See TracTickets for help on using tickets.